Skip to content

Add native mobile share target support - #4021

Merged
juliusmarminge merged 14 commits into
mainfrom
t3code/mobile-share-target
Jul 16, 2026
Merged

Add native mobile share target support#4021
juliusmarminge merged 14 commits into
mainfrom
t3code/mobile-share-target

Show shared task context in the route header

1381fc9
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Jul 16, 2026 in 44s

Effect Service Conventions: No issues found

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — reasoning, no tool calls

💭 I'm examining the diff to check for Effect service convention violations. Looking at the modified files, I see that incoming-share-storage.ts defines an error class using Schema.TaggedErrorClass, while incoming-share-model.ts imports from effect/Schema, and the tests use @effect/vitest. Most of this code appears to be standard TypeScript rather than actual Effect services, so I need to determine if there are actual convention violations here. The IncomingShareStorageError class extends Schema.TaggedErrorClass with a multi-value operation discriminator and derives its message from structural attributes, which aligns with the convention for service-level errors. The imports use the correct namespace subpath (effect/Schema), so that checks out. Now I'm looking at what's in incoming-share-model.ts to see if there are any other issues. The error handling looks solid—the cause field preserves the underlying error without stringifying it, and the operation discriminator is multi-valued so there's no redundant encoding. These aren't Effect services since they don't define Context.Service, just plain TypeScript with Effect error classes, so the conventions don't strictly apply here. Let me verify whether any file actually defines a service or if this is all clear. I'm wrestling with whether to follow the customer's instruction to respond with exactly "All clear" when there are no findings, or to stick with the JSON schema that the system requires. The schema is mandatory from the harness, but the "All clear" directive is the customer's explicit instruction. I think I need to verify there actually are no findings by checking the relevant files more carefully before deciding how to respond. I'm verifying that the Effect imports are handled correctly across the diff, and I'm confident the new code follows the established conventions—it's straightforward TypeScript with Schema validation rather than Effect services. The error structure is fine, and there's no redundancy issue with the discriminator. I'll mark this as all clear and format the response as JSON with the summary. I've reviewed the files thoroughly and none of them define a Context.Service, so the only Effect integration is through Schema usage. I'm confident there are no issues to report.


Agent Credits: 48 credits