Skip to content

fix(cursor): default binary path to cursor-agent PR Description - #3481

Closed
Aditya190803 wants to merge 2 commits into
pingdotgg:mainfrom
Aditya190803:fix/cursor-default-binary-path
Closed

fix(cursor): default binary path to cursor-agent PR Description#3481
Aditya190803 wants to merge 2 commits into
pingdotgg:mainfrom
Aditya190803:fix/cursor-default-binary-path

Conversation

@Aditya190803

@Aditya190803 Aditya190803 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #3479

When Grok CLI is installed alongside Cursor, the shared agent command name resolves to Grok and breaks Cursor ACP discovery. Default Cursor to cursor-agent, map legacy agent configs on decode, and align update probes and spawn fallbacks with the new binary name.

What Changed

  • Changed the default Cursor binaryPath from agent to cursor-agent
  • Added decode-time migration so existing configs with binaryPath: "agent" resolve to cursor-agent (explicit full paths are unchanged)
  • Updated Cursor ACP spawn fallbacks, provider update probes, and related tests to use cursor-agent

Why

T3 was invoking agent acp for Cursor provider discovery. On machines where both Grok CLI and Cursor are installed, agent often resolves to Grok first, causing Cursor ACP model discovery to fail with AcpTransportError even though cursor-agent works correctly.

cursor-agent is the correct Cursor CLI binary name and avoids this collision. Mapping legacy "agent" values preserves existing user configs without requiring a manual settings change.

UI Changes

N/A — server-side provider discovery and settings default only. The settings placeholder now shows cursor-agent instead of agent.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Scoped to Cursor provider binary path defaults and decode-time normalization in settings; no auth, data, or broad behavioral changes beyond which executable is invoked.

Overview
Cursor provider settings now default binaryPath to cursor-agent instead of agent, avoiding PATH collisions when Grok CLI also installs an agent command and breaking Cursor ACP discovery.

The contracts layer adds normalizeCursorBinaryPath and a dedicated decode path via makeCursorBinaryPathSetting: empty values default to cursor-agent, stored "agent" is rewritten to cursor-agent on read, and explicit paths (e.g. /usr/local/bin/agent) are left unchanged. The settings form placeholder is updated to cursor-agent. Unit tests cover default, legacy, and explicit-path behavior.

Reviewed by Cursor Bugbot for commit 220eab8. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Default CursorSettings.binaryPath to cursor-agent and migrate legacy agent value

Updates the binaryPath field in CursorSettings to use a new makeCursorBinaryPathSetting() builder in settings.ts. Missing or empty values decode to 'cursor-agent', and the legacy value 'agent' is remapped to 'cursor-agent'. Explicit absolute paths are preserved as-is.

Macroscope summarized 220eab8.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: db5930a5-0030-4afb-80f8-bddd317bdd0a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). size:S 10-29 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jun 21, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Straightforward backwards-compatibility fix that normalizes a legacy binary path value during config decoding. The logic is simple string transformation with comprehensive test coverage.

You can customize Macroscope's approvability policy. Learn more.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4608306a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/server/src/provider/Drivers/CursorDriver.ts Outdated
@Aditya190803

Copy link
Copy Markdown
Contributor Author

@juliusmarminge
hey, when you get a chance could you take a look at this?
small fix for cursor binary path colliding with grok

When Grok CLI is installed alongside Cursor, the shared `agent` command
name resolves to Grok and breaks Cursor ACP discovery. Default Cursor to
`cursor-agent`, map legacy `agent` configs on decode, and align update
probes and spawn fallbacks with the new binary name.
@Aditya190803
Aditya190803 force-pushed the fix/cursor-default-binary-path branch from 68b4825 to 220eab8 Compare July 18, 2026 11:27
@juliusmarminge

Copy link
Copy Markdown
Member

Seems a bit silly to block agent completely which this does if I'm not mistaken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Cursor binary to cursor-agent to avoid Grok agent collision

2 participants