fix(cursor): default binary path to cursor-agent PR Description - #3481
fix(cursor): default binary path to cursor-agent PR Description#3481Aditya190803 wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Straightforward backwards-compatibility fix that normalizes a legacy binary path value during config decoding. The logic is simple string transformation with comprehensive test coverage. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4608306a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@juliusmarminge |
When Grok CLI is installed alongside Cursor, the shared `agent` command name resolves to Grok and breaks Cursor ACP discovery. Default Cursor to `cursor-agent`, map legacy `agent` configs on decode, and align update probes and spawn fallbacks with the new binary name.
68b4825 to
220eab8
Compare
|
Seems a bit silly to block |
Fixes #3479
When Grok CLI is installed alongside Cursor, the shared
agentcommand name resolves to Grok and breaks Cursor ACP discovery. Default Cursor tocursor-agent, map legacyagentconfigs on decode, and align update probes and spawn fallbacks with the new binary name.What Changed
binaryPathfromagenttocursor-agentbinaryPath: "agent"resolve tocursor-agent(explicit full paths are unchanged)cursor-agentWhy
T3 was invoking
agent acpfor Cursor provider discovery. On machines where both Grok CLI and Cursor are installed,agentoften resolves to Grok first, causing Cursor ACP model discovery to fail withAcpTransportErroreven thoughcursor-agentworks correctly.cursor-agentis the correct Cursor CLI binary name and avoids this collision. Mapping legacy"agent"values preserves existing user configs without requiring a manual settings change.UI Changes
N/A — server-side provider discovery and settings default only. The settings placeholder now shows
cursor-agentinstead ofagent.Checklist
Note
Low Risk
Scoped to Cursor provider binary path defaults and decode-time normalization in settings; no auth, data, or broad behavioral changes beyond which executable is invoked.
Overview
Cursor provider settings now default
binaryPathtocursor-agentinstead ofagent, avoiding PATH collisions when Grok CLI also installs anagentcommand and breaking Cursor ACP discovery.The contracts layer adds
normalizeCursorBinaryPathand a dedicated decode path viamakeCursorBinaryPathSetting: empty values default tocursor-agent, stored"agent"is rewritten tocursor-agenton read, and explicit paths (e.g./usr/local/bin/agent) are left unchanged. The settings form placeholder is updated tocursor-agent. Unit tests cover default, legacy, and explicit-path behavior.Reviewed by Cursor Bugbot for commit 220eab8. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Default
CursorSettings.binaryPathtocursor-agentand migrate legacyagentvalueUpdates the
binaryPathfield inCursorSettingsto use a newmakeCursorBinaryPathSetting()builder in settings.ts. Missing or empty values decode to'cursor-agent', and the legacy value'agent'is remapped to'cursor-agent'. Explicit absolute paths are preserved as-is.Macroscope summarized 220eab8.