Skip to content

Release 6.5.11 hotfix 20260623#10911

Open
ChenNingjie1218 wants to merge 12 commits into
pingcap:release-6.5from
ChenNingjie1218:release-6.5.11-hotfix-20260623
Open

Release 6.5.11 hotfix 20260623#10911
ChenNingjie1218 wants to merge 12 commits into
pingcap:release-6.5from
ChenNingjie1218:release-6.5.11-hotfix-20260623

Conversation

@ChenNingjie1218

Copy link
Copy Markdown

What problem does this PR solve?

Issue Number: ref #10337

Problem Summary:

Backport the exchange sender memory usage limit from #10387 to the v6.5.11 hotfix baseline for HF-1041.

This PR is opened only to trigger upstream GitHub CI for the hotfix and should not be merged.

What is changed and how it works?

  • Add max_buffered_bytes_in_executor and propagate it to DAG/MPP response writers.
  • Flush buffered rows by byte threshold to limit exchange sender memory usage.
  • Add/adapt unit tests for streaming and MPP exchange writers.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

windtalker and others added 7 commits June 23, 2026 17:11
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
(cherry picked from commit 0bd20e8)
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
(cherry picked from commit ffb2f0a)
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
(cherry picked from commit 71b271f)
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
(cherry picked from commit e8d4a5e)
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
(cherry picked from commit 9ae2aee)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
(cherry picked from commit 45bacf0)
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
(cherry picked from commit b798acf)
@ti-chi-bot

ti-chi-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jun 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign schrodingerzhu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • release-8.5
  • release-7.5
  • release-8.1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 809687f4-0e34-4db7-817e-92efd8430f13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Hi @ChenNingjie1218. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jun 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Welcome @ChenNingjie1218!

It looks like this is your first PR to pingcap/tiflash 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tiflash. 😃

@kumailf

kumailf commented Jun 24, 2026

Copy link
Copy Markdown

/retest-required

@ti-chi-bot

ti-chi-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@kumailf: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iamxy

iamxy commented Jun 24, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 24, 2026
@pingcap-cla-assistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ windtalker
❌ ningjie.chen


ningjie.chen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ChenNingjie1218

Copy link
Copy Markdown
Author

/retest

@kumailf

kumailf commented Jun 24, 2026

Copy link
Copy Markdown

/test pull-integration-test

1 similar comment
@kumailf

kumailf commented Jun 25, 2026

Copy link
Copy Markdown

/test pull-integration-test

@ChenNingjie1218

Copy link
Copy Markdown
Author

/retest-required

@ChenNingjie1218

Copy link
Copy Markdown
Author

/test pull-integration-test

@ChenNingjie1218

Copy link
Copy Markdown
Author

/test pull-unit-test

1 similar comment
@ChenNingjie1218

Copy link
Copy Markdown
Author

/test pull-unit-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. do-not-merge/cherry-pick-not-approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants