Repository navigation
Drop testify for stdlib test helpers - #3
Merged
Merged
Conversation
The cache had no runtime dependencies, only testify in the tests. The assertions it provided fit in one small file, so the module now has none at all and go.sum is gone. assert* reports and continues, require* stops the test: the concurrency tests assert from goroutines, where t.Fatal is not allowed. Go stays at 1.22. testing/synctest would have made the sleeping concurrency tests instant and deterministic, but locking a mutex is not durably blocking, so the keyed-mutex waiters deadlock the bubble clock. Nothing else needed a newer version. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache had no runtime dependencies, only testify in the tests. The assertions it provided fit in one small file, so the module now has none at all and go.sum is gone.
assert* reports and continues, require* stops the test: the concurrency tests assert from goroutines, where t.Fatal is not allowed.
Go stays at 1.22. testing/synctest would have made the sleeping concurrency tests instant and deterministic, but locking a mutex is not durably blocking, so the keyed-mutex waiters deadlock the bubble clock. Nothing else needed a newer version.