feat: support iso-8859-8-i and iso-8859-8-e charset labels#394
Open
baptistejamin wants to merge 2 commits into
Open
feat: support iso-8859-8-i and iso-8859-8-e charset labels#394baptistejamin wants to merge 2 commits into
baptistejamin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there.
iconv-lite is used by a library we rely on: mailparser, which we use at Crisp.
We've received Hebrew emails with
charset="iso-8859-8-i", and they aren't decoded properly by iconv-lite.Right now,
encodingExists('iso-8859-8-i')returnsfalseanddecode(buf, 'iso-8859-8-i')throwsEncoding not recognized.iso-8859-8-iandiso-8859-8-eare valid ISO charset names. The-i/-esuffix only describes text directionality (logical vs. visual BiDi order).What this PR does
iso88598iandiso88598eas aliases ofiso88598inencodings/sbcs-data.js, next to the existinghebrew/csisolatinhebrewaliases.lib/index.jsalready strips the dashes (iso-8859-8-i→iso88598i), so both the dashed header form and the canonical form now resolve correctly.types/encodings.d.tsThe code was partially written with Cursor and Opus 4.8, and I reviewed it myself; it's an easy and safe PR.