chore: promote dev to master - #2329
Merged
Merged
Conversation
…ct-draggable 4.x acts on the value returned by DraggableCore's onStop andreturns early, before it removes the document mousemove/mouseup listeners.3.3.2 ignored that value and always removed them, so returning false was inert -which is what the old comment assumed. On v4 every handle you drag staysattached to the document, so released marks keep following the cursor: incharting a line's points all move together, and in graphing andgraphing-solution-set marks drift off the graph and disappear.The behaviour was introduced upstream in react-draggable 4.3.0. pie-lib pickedit up with the bump in PIE-926; pie-elements-ng has had it since its own move to^4.6.0. grid-draggable is synced from pie-lib, so the fix carries over there.Adds a regression test for both a released handle and a second handle beingdragged.Also drops the componentWillReceiveProps override on plot's Draggable, which v4makes unreachable via its static getDerivedStateFromProps, and replaces twoassertion-free tests with ones that check the real transform.
fix(deps): align versions with pie-elements-ng and upgrade @visx to v4 PIE-926, PIE-972
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.11 to 3.3.18. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/3.3.18/CHANGELOG.md) - [Commits](ai/nanoid@3.3.11...3.3.18) --- updated-dependencies: - dependency-name: nanoid dependency-version: 3.3.18 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.28.1 to 4.28.8. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.28.1...4.28.8) --- updated-dependencies: - dependency-name: browserslist dependency-version: 4.28.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…anoid-3.3.18 build(deps): bump nanoid from 3.3.11 to 3.3.18
…rowserslist-4.28.8 build(deps): bump browserslist from 4.28.1 to 4.28.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.