fix(extended-text-entry): honor the player spellcheck setting PIE-978 - #3113
Merged
Conversation
Students were still getting red underlines in the response area even when the item asked for spellcheck to be off. The editor prop over in pie-lib is opt-out, so we need to hand it a real boolean instead of leaving it undefined. The controller was negating playerSpellCheckDisabled, which is fine for a missing key but not for one present as undefined or null. It now checks for an explicit false, so spellcheck only comes on when the author actually asked for it. Tests cover all five cases, plus the prop making it to the editor.
Follows up the tests with the actual controller change: an explicit false check instead of negating playerSpellCheckDisabled, so a key present as undefined or null no longer switches spellcheck on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://illuminate.atlassian.net/browse/PIE-978