Dashboard: Local DNS Records, 1column layout + option of editing records.#3794
Dashboard: Local DNS Records, 1column layout + option of editing records.#3794brazier wants to merge 8 commits into
Conversation
* Changed the layout to a one column full with stacking one. * Added the option to edit dns/cname records Signed-off-by: Alexander H. Olsen <alexander@linux.com>
Refactor poc to use the same button helper. Signed-off-by: Alexander H. Olsen <alexander@linux.com>
Merge upstream development Signed-off-by: Alexander H. Olsen <alexander@linux.com>
This is reverted in dev with #3778 |
Note: This only happens when using the "boxed layout". Your new layout will be too wide on big screens. |
Prettier fail CI Signed-off-by: Alexander H. Olsen <alexander@linux.com>
Revert back to a 2 column layout, works better with non-boxed mode. Signed-off-by: Alexander H. Olsen <alexander@linux.com>
I have never noticed that before after using pi-hole for so many years. Thanks! and reverted. And now rocking the non-boxed mode. |
|
Ill fix the failures first. |
XO fixes Signed-off-by: Alexander H. Olsen <alexander@linux.com>
yes, but it wasnt what i wanted. there is no way to sort that list, subdomains that are added later end up in the incorrect spots. If i were to edit them in advanced i may aswell edit the file directly on the filesystem instead. |
Signed-off-by: Alexander H. Olsen <alexander@linux.com>


What does this PR aim to accomplish?:
I have a lot of Local DNS records and always felt the the 2 column layout was small and didnt match the rest of Pi-hole.I also tend to change records often for testing or other purposes. Delteting and then re-adding felt uneccesary.
Old screenshots
How does this PR accomplish the above?:
The Local DNS records page now has a one column stacked layout, with the option to edit each line as needed.I do understand that the 1 vs 2 column layoutis a matter of taste, and while it is what i like i do understand others may not. The edit feature can if needed be kept while reverting to a 2 column layout.(2 lines)
Im not to happy with the width of the icons as they differ, fa-fw makes them to wide(1.25 em) would preferd to set them to 1 em but wanted input here.
--
As i was working with this i did notice that some tend to use i while others span for fa icons so i didnt think so much about which to use for consistency. Can rewrite if there is a new preferred one.
By submitting this pull request, I confirm the following:
git rebase)I have read the above and my PR is ready for review. Check this box to confirm