Skip to content

Dashboard: Local DNS Records, 1column layout + option of editing records.#3794

Open
brazier wants to merge 8 commits into
pi-hole:developmentfrom
brazier:feat/dnsrecords-edit
Open

Dashboard: Local DNS Records, 1column layout + option of editing records.#3794
brazier wants to merge 8 commits into
pi-hole:developmentfrom
brazier:feat/dnsrecords-edit

Conversation

@brazier

@brazier brazier commented Jun 3, 2026

Copy link
Copy Markdown

What does this PR aim to accomplish?:
I have a lot of Local DNS records and always felt the the 2 column layout was small and didnt match the rest of Pi-hole.
I also tend to change records often for testing or other purposes. Delteting and then re-adding felt uneccesary.

Skjermbilde 2026-06-03 225827
Old screenshots Skjermbilde 2026-06-03 182016 Skjermbilde 2026-06-03 181934

How does this PR accomplish the above?:

The Local DNS records page now has a one column stacked layout, with the option to edit each line as needed.
I do understand that the 1 vs 2 column layoutis a matter of taste, and while it is what i like i do understand others may not. The edit feature can if needed be kept while reverting to a 2 column layout.(2 lines)

Im not to happy with the width of the icons as they differ, fa-fw makes them to wide(1.25 em) would preferd to set them to 1 em but wanted input here.

--
As i was working with this i did notice that some tend to use i while others span for fa icons so i didnt think so much about which to use for consistency. Can rewrite if there is a new preferred one.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

brazier added 4 commits June 3, 2026 21:17
Fix typo

Signed-off-by: Alexander H. Olsen <alexander@linux.com>
* Changed the layout to a one column full with stacking one.
* Added the option to edit dns/cname records

Signed-off-by: Alexander H. Olsen <alexander@linux.com>
Refactor poc to use the same button helper.

Signed-off-by: Alexander H. Olsen <alexander@linux.com>
Merge upstream development

Signed-off-by: Alexander H. Olsen <alexander@linux.com>
@brazier brazier requested a review from a team as a code owner June 3, 2026 20:14
@yubiuser

yubiuser commented Jun 3, 2026

Copy link
Copy Markdown
Member

I went with v as both the master and dev branched used that in settings-dns-records.js prior.

This is reverted in dev with #3778

@rdwebdesign

Copy link
Copy Markdown
Member

I have a lot of Local DNS records and always felt the the 2 column layout was small and didnt match the rest of Pi-hole.

Note:

This only happens when using the "boxed layout".

Your new layout will be too wide on big screens.

brazier added 2 commits June 3, 2026 22:39
Prettier fail CI

Signed-off-by: Alexander H. Olsen <alexander@linux.com>
Revert back to a 2 column layout, works better with non-boxed mode.

Signed-off-by: Alexander H. Olsen <alexander@linux.com>
@brazier

brazier commented Jun 3, 2026

Copy link
Copy Markdown
Author

I have a lot of Local DNS records and always felt the the 2 column layout was small and didnt match the rest of Pi-hole.

Note:

This only happens when using the "boxed layout".

Your new layout will be too wide on big screens.

I have never noticed that before after using pi-hole for so many years. Thanks! and reverted. And now rocking the non-boxed mode.

@brazier

brazier commented Jun 3, 2026

Copy link
Copy Markdown
Author

Ill fix the failures first.

XO fixes

Signed-off-by: Alexander H. Olsen <alexander@linux.com>
@rdwebdesign

Copy link
Copy Markdown
Member

Just one more question:

I also tend to change records often for testing or other purposes. Delteting and then re-adding felt uneccesary.

Did you try to use the Advanced settings page to edit this?

If you need to change the list too often, using the advanced settings would be a lot easier:

image image

@brazier

brazier commented Jun 3, 2026

Copy link
Copy Markdown
Author

Just one more question:

I also tend to change records often for testing or other purposes. Delteting and then re-adding felt uneccesary.

Did you try to use the Advanced settings page to edit this?

If you need to change the list too often, using the advanced settings would be a lot easier:
....

yes, but it wasnt what i wanted. there is no way to sort that list, subdomains that are added later end up in the incorrect spots. If i were to edit them in advanced i may aswell edit the file directly on the filesystem instead.

Signed-off-by: Alexander H. Olsen <alexander@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants