Skip to content

feature: error callback #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
g105b merged 1 commit into from
Jan 7, 2026
Merged

feature: error callback #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Schema/JsonDocument.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

class JsonDocument {
private bool $hasError = false;
/** @var callable */
private $errorCallback;

public function __construct(
private ?JsonObject $jsonObject = null,
Expand Down Expand Up @@ -77,6 +79,13 @@ public function error(
}

$this->hasError = true;
if(isset($this->errorCallback)) {
call_user_func($this->errorCallback, $message, $context);
}
}

public function setErrorCallback(callable $callback):void {
$this->errorCallback = $callback;
}

/**
Expand Down
29 changes: 29 additions & 0 deletions test/phpunit/Schema/JsonDocumentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,33 @@ public function testError_disallowsSetAfterError():void {
$sut->error("This is an error");
$sut->set("one", "example");
}

public function testSetErrorCallback():void {
$calls = [];
$callback = function(string $message, ?array $context = null)use(&$calls):void {
array_push($calls, [$message, $context]);
};

$sut = new JsonDocument();
$sut->setErrorCallback($callback);

$sut->error("Test");
self::assertCount(1, $calls);
self::assertSame("Test", $calls[0][0]);
self::assertNull($calls[0][1]);
}

public function testSetErrorCallback_context():void {
$calls = [];
$callback = function(string $message, ?array $context = null)use(&$calls):void {
array_push($calls, [$message, $context]);
};

$sut = new JsonDocument();
$sut->setErrorCallback($callback);

$sut->error("Test", ["example" => "message"]);
self::assertCount(1, $calls);
self::assertSame(["example" => "message"], $calls[0][1]);
}
}