[BUGFIX] Read project version from the DOM so "0.10" is not coerced to 0.1

packages/guides-cli/src/Config/XmlFileLoader.php

@@ -13,6 +13,8 @@
 
 namespace phpDocumentor\Guides\Cli\Config;
 
+use DOMAttr;
+use DOMElement;
 use Symfony\Component\Config\Loader\FileLoader;
 use Symfony\Component\Config\Util\Exception\XmlParsingException;
 use Symfony\Component\Config\Util\XmlUtils;
@@ -22,6 +24,7 @@
 use function is_array;
 use function is_string;
 use function sprintf;
+use function trim;
 
 final class XmlFileLoader extends FileLoader
 {
@@ -36,9 +39,45 @@ public function load(mixed $resource, string|null $type = null): array
             throw new XmlParsingException(sprintf('The XML file "%s" is not valid.', $resource));
         }
 
+        // The <project> attributes (title, version, release, copyright) are all
+        // strings and are read from the DOM directly. XmlUtils::convertDomElementToArray()
+        // below runs phpize() on every attribute value, which coerces version-like
+        // strings into numbers ("0.10" would become the float 0.1, "1.0" would
+        // become 1). Reading them straight from the DOM and detaching <project>
+        // beforehand keeps the version exactly as written.
+        $projectConfig = null;
+        $project = $element->getElementsByTagName('project')->item(0);
+        if ($project instanceof DOMElement) {
+            $projectConfig = [];
+            foreach ($project->attributes as $attribute) {
+                if (!($attribute instanceof DOMAttr)) {
+                    continue;
+                }
+
+                $value = $attribute->value;
+
+                // Backward compatibility: to stop the previous phpize() call from
+                // turning a version into a number, consumers wrapped it in single
+                // quotes (e.g. version="'3.0'"). The value is now read straight from
+                // the DOM so the quotes are no longer needed, but existing guides.xml
+                // files may still contain them; strip them for these two attributes.
+                if ($attribute->name === 'version' || $attribute->name === 'release') {
+                    $value = trim($value, "'");
+                }
+
+                $projectConfig[$attribute->name] = $value;
+            }
+
+            $project->parentNode?->removeChild($project);
+        }
+
         $rootConfig = XmlUtils::convertDomElementToArray($element);
         assert(is_array($rootConfig));
 
+        if ($projectConfig !== null) {
+            $rootConfig['project'] = $projectConfig;
+        }
+
         $configs = [];
         if (isset($rootConfig['import'])) {
             foreach ((array) $rootConfig['import'] as $import) {

packages/guides/src/DependencyInjection/GuidesExtension.php

@@ -43,11 +43,8 @@
 use function assert;
 use function dirname;
 use function is_array;
-use function is_int;
 use function is_string;
 use function pathinfo;
-use function trim;
-use function var_export;
 
 final class GuidesExtension extends Extension implements CompilerPassInterface, ConfigurationInterface, PrependExtensionInterface
 {
@@ -64,42 +61,8 @@ public function getConfigTreeBuilder(): TreeBuilder
                 ->arrayNode('project')
                     ->children()
                         ->scalarNode('title')->end()
-                        ->scalarNode('version')
-                            ->beforeNormalization()
-                            ->always(
-                                // We need to revert the phpize call in XmlUtils. Version is always a string!
-                                static function ($value) {
-                                    if (!is_int($value) && !is_string($value)) {
-                                        return var_export($value, true);
-                                    }
-
-                                    if (is_string($value)) {
-                                        return trim($value, "'");
-                                    }
-
-                                    return $value;
-                                },
-                            )
-                            ->end()
-                        ->end()
-                        ->scalarNode('release')
-                            ->beforeNormalization()
-                            ->always(
-                            // We need to revert the phpize call in XmlUtils. Version is always a string!
-                                static function ($value) {
-                                    if (!is_int($value) && !is_string($value)) {
-                                        return var_export($value, true);
-                                    }
-
-                                    if (is_string($value)) {
-                                        return trim($value, "'");
-                                    }
-
-                                    return $value;
-                                },
-                            )
-                            ->end()
-                        ->end()
+                        ->scalarNode('version')->end()
+                        ->scalarNode('release')->end()
                         ->scalarNode('copyright')->end()
                     ->end()
                 ->end()

tests/Integration/tests/meta/version-from-guides-xml-quoted/expected/index.html

@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <title>Some Document - Render guides</title>
+
+</head>
+<body>
+<!-- content start -->
+    <div class="section" id="some-document">
+            <h1>Some Document</h1>
+
+    <p>Project Render guides in version 3.0, release 3.0.0.</p>
+
+    </div>
+<!-- content end -->
+</body>
+</html>

tests/Integration/tests/meta/version-from-guides-xml-quoted/input/guides.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<guides
+    xmlns="https://www.phpdoc.org/guides"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="https://www.phpdoc.org/guides vendor/phpdocumentor/guides-cli/resources/schema/guides.xsd"
+>
+    <project
+            title="Render guides"
+            version="'3.0'"
+            release="'3.0.0'"
+    />
+</guides>

tests/Integration/tests/meta/version-from-guides-xml-quoted/input/index.rst

@@ -0,0 +1,4 @@
+Some Document
+=============
+
+Project |project| in version |version|, release |release|.

tests/Integration/tests/meta/version-from-guides-xml/expected/index.html

@@ -1,8 +1,17 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <title>Some Document - Render guides</title>
+
+</head>
+<body>
 <!-- content start -->
     <div class="section" id="some-document">
             <h1>Some Document</h1>
-
-    <p>Project Render guides in version 3.0, release 3.0.0.</p>
+            
+    <p>Project Render guides in version 0.10, release 3.0.0.</p>
 
     </div>
 <!-- content end -->
+</body>
+</html>

tests/Integration/tests/meta/version-from-guides-xml/input/guides.xml

@@ -6,7 +6,7 @@
 >
     <project
             title="Render guides"
-            version="'3.0'"
+            version="0.10"
             release="3.0.0"
     />
 </guides>