Increase minimum uriparser version dependency for ext/uri#22575
Open
kocsismate wants to merge 1 commit into
Open
Increase minimum uriparser version dependency for ext/uri#22575kocsismate wants to merge 1 commit into
kocsismate wants to merge 1 commit into
Conversation
uriparser 1.0.3 needs to be released to add the missing symbols to be able to build PHP with the "--with-external-uriparser" option. Closes php#22553
TimWolla
approved these changes
Jul 3, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
Small request regarding PR / commit messages: I try to prefix the commit message by the extension, that makes it easier to scan the commit list. So “uri: Increase minimum version for external uriparser” or something like this
DanielEScherzer
left a comment
DanielEScherzer
left a comment
Member
There was a problem hiding this comment.
Should this wait until 1.0.3 is actually released? uriparser/uriparser#333 suggests that it won't happen for another month
Member
No. Building PHP 8.6 with older versions will just be broken with an obscure error message, so better have a clear error message. The bundled version of uriparser is not affected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uriparser 1.0.3 needs to be released to add the missing symbols to be able to build PHP with the "--with-external-uriparser" option.
Closes #22553