Add a warning to the JS Hook documentation for changing phx-hook#3509
Closed
Gazler wants to merge 1 commit into
Closed
Add a warning to the JS Hook documentation for changing phx-hook#3509Gazler wants to merge 1 commit into
Gazler wants to merge 1 commit into
Conversation
Member
|
@Gazler I think we could also make this work instead of just documenting that it doesn't |
| > ```javascript | ||
| > hooks.MyHook = { | ||
| > updated: { | ||
| > if (this.el.getAttribute("data-hook-enabled") !== "false")) { |
Contributor
There was a problem hiding this comment.
Suggested change
| > if (this.el.getAttribute("data-hook-enabled") !== "false")) { | |
| > if (this.el.dataset.hookEnabled !== "false") { |
Contributor
There was a problem hiding this comment.
i prefer "data-hook-enabled" for the fact being is much easier to search for it globally. There is no benefit of one over the other.
Member
|
fwiw there's #4153 which would allow changing hooks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.