CI shadow: fix5661-final (#5763) - #1
Open
philphauler wants to merge 4 commits into
Open
philphauler wants to merge 4 commits into
philphauler wants to merge 4 commits into
Conversation
…RNING events When paused, updateDebugTelemetryStruct() calls deserializeDirective() on every telemetry tick. If the directive fails to deserialize, a WARNING_HI event repeats at the telemetry rate. Caches the statement index so the event fires only once per statement. Fixes nasa#5661
sylvesterkaczmarek: m_debug.cachedStmtIndex was not cleared in resetRuntime(), causing the cached-deserialization optimization to skip deserialize when a new sequence starts at the same statement index as the previous one. Set to 0xFFFFFFFF (sentinel for 'no cached entry') so the first statement in any new sequence always deserializes properly.
- tlmWriteDebugCachesFailedDeserialize: paused on a statement that fails to deserialize, two telemetry ticks emit exactly one DirectiveDeserializeError; the cached path still refreshes Debug_StackSize. Without the fix: two events. - tlmWriteDebugCacheKeyedOnStatementIndex: moving to a different failing statement emits a fresh event for that index. - tlmWriteDebugCacheClearedOnRuntimeReset: cancel and run a second sequence whose statement 0 also fails; the first tick must emit a new event. Without invalidating cachedStmtIndex in resetRuntime the stale entry short-circuits and nothing is emitted for the new sequence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only CI preflight for nasa#5763. Not for review.