Fix incorrect channel mapping in My Subscriptions - #92
Open
FLeXO21 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
My Subscriptionscould show the wrong channel contents when selectinga subscription, especially when the subscription list spans multiple
pages.
The subscriptions were fetched in paginated batches and then sorted
locally by title using
_renderList(..., 'title'). This can make theordering inconsistent between pagination requests, causing the displayed
subscription to no longer correspond to the expected channel.
This change lets the YouTube API perform the sorting instead:
order => 'alphabetical'to the subscriptions requestTested on a running Lyrion Media Server installation where the issue
was reproducible before the change.
Before:
After: