fix feedback to user when something goes wrong in insert superclass/subclass refactor - #19994
Open
estebanlm wants to merge 4 commits into
Open
fix feedback to user when something goes wrong in insert superclass/subclass refactor#19994estebanlm wants to merge 4 commits into
estebanlm wants to merge 4 commits into
Conversation
…efactor. I also took the oportunity to caught any error happened in the refactor and transform it into an inform with an error message (most users will not do anythign with a debugger, and since the pre-debug window is gone, this feels horrible).
estebanlm
changed the title
Member
Author
|
apparently the errors are unrelated |
Ducasse
reviewed
Sep 11, 2026
| @@ -0,0 +1,11 @@ | |||
| " | |||
| ""Handles command !<anInteger> and return (if it exists) the command related to the number | |||
Member
There was a problem hiding this comment.
Esteban I do not know if this changes is wished or not.
Member
Author
There was a problem hiding this comment.
crap, not... that sneaked in when commiting :P
Ducasse
reviewed
Sep 11, 2026
| self deny: universalEnvironment isClassEnvironment. | ||
| self assert: aClassEnvironment isClassEnvironment. | ||
| self assert: aClassEnvironment packages size equals: 1. | ||
| self deny: (universalEnvironment isClassEnvironment). |
Member
There was a problem hiding this comment.
We do not need the parentheses.
Ducasse
reviewed
Sep 11, 2026
| StRefactoringAddClassPresenterTest >> testClassNameInputIsRecordedInDriver [ | ||
| | driver | | ||
|
|
||
| driver := presenter instVarNamed: 'driver'. |
Member
There was a problem hiding this comment.
why not using an accessor?
It makes sense that we can access the driver of a presenter.
Member
Author
There was a problem hiding this comment.
indeed. It was not me who did that !
Ducasse
reviewed
Sep 11, 2026
also, minimal clean up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as there is no feedback, is sometimes confusing to not know what is happening.
this PR handles the inform to the user of things that are happening.
Fixes #19988
Fixes #19987
I also took the oportunity to caught any error happened in the refactor and transform it into an inform with an error message (most users will not do anything with a debugger other than close it with a bad feeling, and since the pre-debug window is gone, this feels horrible., so better to just send a message of what went wrong).