Skip to content

Add an #identityHash check to prevent the recursive image lockup that… #19911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdebruic wants to merge 1 commit into
base: Pharo15
Choose a base branch
from
+10 −4
Open

Add an #identityHash check to prevent the recursive image lockup that… #19911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/Collections-Abstract/Collection.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,11 +891,17 @@ Collection >> hash [
-- two equal objects have equal hash values"

| hash |

hash := self species hash.
self size <= 10 ifTrue:
[self do: [:elem | hash := hash bitXor: elem hash]].
^hash bitXor: self size hash
self size <= 10 ifTrue: [
| identity elemIdentityHash elemHash |
identity := self identityHash.
self do: [ :elem |
elemIdentityHash := elem identityHash.
elemHash := elemIdentityHash = identity
ifTrue: [ elemIdentityHash ]
ifFalse: [ elem hash ].
hash := hash bitXor: elemHash ] ].
^ hash bitXor: self size hash
]

{ #category : 'testing' }
Expand Down