Conversation
tesonep
commented
Mar 1, 2025
tesonep
commented
Collaborator
- Adding new Bytecode to perform SameThread callouts
- Having a JIT implementation of the bytecode
- Support for optimizations on specific set of signatures
- Supported in ARM32, ARM64 and X86_64
…ject. It pins the object if it is not pinned. - Adding JIT version of this primitive - Adding tests
- Adding a new bytecode for SameThreadCallout - Adding general JIT implementation using a trampoline - Adding Tests Based in the work and experiments of Juan Ignacio Bianchi
- Fixing issues with callbacks - Annotating the bytecode correctly - Starting to add support for optimizations
…be externalized before
…calized variables (they leave the interpreter)
- Improving optimized code - Adding tests - Fixing types
- Implementing some optimizations - Implementing it for ARM32 / ARM64 / X64 (SysV & WIN) - Supporting flags to optimize the code
…Finder works correctly for the tests
- Adding tests
PalumboN
previously approved these changes
Jun 18, 2025
PalumboN
left a comment
PalumboN
left a comment
Collaborator
There was a problem hiding this comment.
Beautiful ninja magic 🥷 🪄 ✨
👏 👏 👏 👏
| printedString := String streamContents: [ :str | cast prettyPrintOn: str ]. | ||
|
|
||
| self assert: printedString equals: | ||
| self assert: printedString trimBoth trimBoth equals: |
Collaborator
There was a problem hiding this comment.
This class should be in Slang-Tests package (now it is not running on the CI). I though that I already moved it 🤔
Comment on lines
39
to
41
| ^ self new | ||
| codeGenerator: aCodeGenerator; | ||
| codeGenerator: aCodeGenerator | ||
| yourself |
Comment on lines
+4
to
+7
| InstructionClient >> sameThreadCallout: literalIndex [ | ||
|
|
||
|
|
||
| ] |
| ] | ||
|
|
||
| { #category : 'tests - primitiveGetAddressOfOOPPinningIfNeeded' } | ||
| VMPrimitiveTest >> testPrimitiveGetAddressOfOOPPinningIfNeededReturnsAddressAndPinsIfObjectIsNotPinned [ |
Collaborator
There was a problem hiding this comment.
If not pinned this primitive pin it on the interpreter but not on the JIT, right?
…he code compaction and the movements of machine code methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.