fix: slope rules table clearing and data corruption on row removal (#1302)#1341
Open
wangzhengdna-lang wants to merge 2 commits into
Open
fix: slope rules table clearing and data corruption on row removal (#1302)#1341wangzhengdna-lang wants to merge 2 commits into
wangzhengdna-lang wants to merge 2 commits into
Task list completed / task-list-completed
Started
2026-06-04 01:18:52
ago
13 / 14 tasks completed
1 task still to be completed
Details
Required Tasks
| Task | Status |
|---|---|
| Slope rules table clears when all rows are removed | Completed |
| Row removal does not corrupt remaining rows (TYPE, RANGE, REASON unchanged) | Completed |
| No extra/ghost columns appear after successive removals | Completed |
| Adding rows after clearing works correctly | Completed |
| Results > Manual Adjustments shows "No rules defined" when rules are empty | Completed |
| Column normalization prevents stray columns from plot-click paths | Completed |
| Edit events are suppressed during widget re-initialization | Completed |
| Code passes lintr checks (only 2 pre-existing cyclocomp warnings, unrelated to this PR) | Completed |
| Code passes all unit tests (1693 pass, 0 fail, 0 warn, 3 skip) | Completed |
New logic covered by unit tests — check_slope_rule_overlap column normalization has 4 new tests |
Completed |
| New logic is documented — CLAUDE.md updated with patterns; inline comments explain suppression guard | Completed |
| App or package changes are reflected in NEWS | Completed |
| Package version is incremented (0.1.0.9175 → 0.1.0.9176) | Completed |
| Settings upload works with the new implementation — requires manual verification (see How to test) | Incomplete |
Loading