Skip to content

ADR - convention router#17377

Merged
niden merged 8 commits into
CP-17341-add-adr-implementationfrom
CP-17341-router-redesign
Jul 18, 2026
Merged

ADR - convention router#17377
niden merged 8 commits into
CP-17341-add-adr-implementationfrom
CP-17341-router-redesign

Conversation

@niden

@niden niden commented Jul 18, 2026

Copy link
Copy Markdown
Member
  • Phalcon\Contracts\ADR\Router\Router + Phalcon\ADR\Router\Router - convention matcher: HTTP method + static path segments resolve the Action class, trailing segments become positional request attributes; match(RequestInterface) / RouterMatch unchanged. Config via setBaseNamespace() / setMiddlewareMap()
  • Middleware resolved from a namespace-prefix map (group semantics); global middleware stays on the pipeline
  • Removed the route table: Route, Group (contract + impl) and the HasMiddleware trait
  • Phalcon\ADR\Responder\RedirectResponder - guard the instanceof behind a typeof == "object" check (was warning on every non-redirect result)
  • Test fixtures under Phalcon\Tests\Support\ADR\Action\* (the matcher resolves real classes via class_exists)

Refs #17341

@niden
niden merged commit 0a6a033 into CP-17341-add-adr-implementation Jul 18, 2026
24 of 144 checks passed
@niden
niden deleted the CP-17341-router-redesign branch July 18, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant