Skip to content

fix: free handles after stop (Windows) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pevers merged 1 commit into from
Nov 20, 2025
Merged

fix: free handles after stop (Windows) #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions nosleep-windows/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@

use nosleep_types::{NoSleepError, NoSleepTrait};
use windows::core::PWSTR;
use windows::Win32::Foundation::HANDLE;
use windows::Win32::Foundation::{CloseHandle, HANDLE};
use windows::Win32::System::Power::{
PowerClearRequest, PowerCreateRequest, PowerRequestDisplayRequired, PowerRequestSystemRequired,
PowerSetRequest, POWER_REQUEST_TYPE,
PowerCreateRequest, PowerRequestDisplayRequired, PowerRequestSystemRequired, PowerSetRequest,
POWER_REQUEST_TYPE,
};
use windows::Win32::System::Threading::{
POWER_REQUEST_CONTEXT_SIMPLE_STRING, REASON_CONTEXT, REASON_CONTEXT_0,
Expand Down Expand Up @@ -117,24 +117,25 @@ impl NoSleepTrait for NoSleep {
fn stop(&mut self) -> Result<(), NoSleepError> {
if let Some(handle) = &self.no_sleep_handle {
unsafe {
PowerClearRequest(handle.system_handle, PowerRequestSystemRequired).map_err(
|e| NoSleepError::StopLock {
reason: e.to_string(),
},
)?;
if let Some(display_handle) = handle.display_handle {
PowerClearRequest(display_handle, PowerRequestDisplayRequired).map_err(
|e| NoSleepError::StopLock {
reason: e.to_string(),
},
)?;
let _ = CloseHandle(display_handle);
}

let _ = CloseHandle(handle.system_handle);
}

self.no_sleep_handle = None;
}
Ok(())
}
}

impl Drop for NoSleep {
fn drop(&mut self) {
let _ = self.stop();
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand All @@ -157,4 +158,12 @@ mod tests {
nosleep.prevent_display_sleep().unwrap();
nosleep.stop().unwrap();
}

#[test]
fn test_start_after_stop() {
let mut nosleep = NoSleep::new().unwrap();
nosleep.prevent_display_sleep().unwrap();
nosleep.stop().unwrap();
nosleep.prevent_display_sleep().unwrap();
}
}
Loading