Skip to content

Improve Recaf ebuild - #2789

Closed
catfromplan9 wants to merge 1 commit into
pentoo:masterfrom
catfromplan9:improve-recaf-ebuild
Closed

Improve Recaf ebuild#2789
catfromplan9 wants to merge 1 commit into
pentoo:masterfrom
catfromplan9:improve-recaf-ebuild

Conversation

@catfromplan9

Copy link
Copy Markdown

No description provided.

blshkv added a commit to blshkv/pentoo-overlay that referenced this pull request May 27, 2026
@blshkv

blshkv commented May 27, 2026

Copy link
Copy Markdown
Contributor

I'm not sure why you deleted some old existing code from the ebuild, I merged it manually. Thanks

@blshkv blshkv closed this May 27, 2026
@catfromplan9

Copy link
Copy Markdown
Author

Wdym deleted old code? I only add new ebuild and .desktop file

@catfromplan9

catfromplan9 commented May 27, 2026

Copy link
Copy Markdown
Author

Oh, that bottom bit on the ebuild? It's not true, please remove it. Just read what it says, and then look what the ebuild does. It does not "download openjfx on first run" that's BS, emerge pulls it in. Maybe the ebuild was originally doing something extremely stupid and that got fixed but the comment was never removed.

@catfromplan9

Copy link
Copy Markdown
Author

Also the src_unpack() is redundant, could you use my provided ebuild instead?

@blshkv

blshkv commented May 28, 2026

Copy link
Copy Markdown
Contributor

dude, I spent hours trying to make this ebuild working, so I know how it works and what it does. If you check your ~/.openjfx, you will be very surprised (with -system-openjfx is disabled by default).
Also, src_unpack is the proper (ala-Gentoo) way. Portage used to fail trying to unpack jar file without it. Additionally, it should not be allowed to install files from DISTFILES directly. It may still fail to install with one of sandbox flags (usersandbox etc) enabled.

So next time when you create a pull, please spend 5 minutes and write a small description what you want to change and why.

@blshkv

blshkv commented May 28, 2026

Copy link
Copy Markdown
Contributor

also, please refer to pst-format/libpst#26 if you need a good example how to fill in a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants