Skip to content

slide-qa hides a slide's clipped content when the same slide also overflows #160

Closed

Description

@pedrohcgs

Revision: 6246c35 (main). Reported by Codex on PR #155 (comment); confirmed against the source.

Observed. scripts/slide-qa.py collapses a slide's defects into one verdict (overflow, then clipped, then broken-asset). A slide that both spills past an edge and hides content inside a scrolling element is counted only as overflow, and report.md lists only the overflow offenders — the clipping is fixed a run later, if at all.
Expected. Each defect category is tracked on its own: summary counts per category, and every category's details listed for the slide.
Done when a seeded slide with both defects is counted in both totals and shows both in its row; single-defect verdicts are unchanged.

Activity

  1. pedrohcgs commented on Sep 27, 2026

    @pedrohcgs
    OwnerAuthor

    Landed on main in #163 (merge commit 97887fc).

    What was wrong. Each slide got one verdict, the first defect found. A slide that overflowed and hid clipped content reported only "overflow", so the clipped content went unreported.

    Fixed in 0425fd6. Each slide now records every defect: overflow, clipped, broken asset. The report's Verdict column lists them all (for example overflow + clipped), and the Where column names the offenders, the hidden content and the broken assets together.

    Checked at 0425fd6: a two-slide deck with both defects on one slide reports overflow + clipped for it (exit 1). The regression decks and the asset deck give the same verdicts as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions