Update apriori.py - #23
Open
ChaselP wants to merge 1 commit into
Open
Conversation
Fixed something about the confidence of a multi items(over 2) frequent set with one-item consequent won't be calculated in function generateRules(). Considerate the situation that a frequent lists L=[[{0},{1},{2}],[{0,1},{1,2},{0,2}],[{0,1,2}],[]], L[2][0]={0,1,2}. The index of this set is 2, which means it will run into the first branch(the rulesFromConseq one) in the original determine statements in line 69(if i>1:). And then in the original function rulesFromConseq(), m=1. So a m+1 items set will be calculated and the confidence of the set with m+1 item consequent was calculated. That is mean the confidence of a multi items(over 2) frequent set with one-item consequent won't be calculated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed something about the confidence of a multi items(over 2) frequent set with one-item consequent won't be calculated in function generateRules(). Considerate the situation that a frequent lists L=[[{0},{1},{2}],[{0,1},{1,2},{0,2}],[{0,1,2}],[]], L[2][0]={0,1,2}. The index of this set is 2, which means it will run into the first branch(the rulesFromConseq one) in the original determine statements in line 69(if i>1:). And then in the original function rulesFromConseq(), m=1. So a m+1 items set will be calculated and the confidence of the set with m+1 item consequent was calculated. That is mean the confidence of a multi items(over 2) frequent set with one-item consequent won't be calculated.