fix(web): reload on stale lazy-chunk load after deploy - #263
Merged
Conversation
Open tabs keep hashed dynamic-import URLs from the previous build; after a deploy those chunks disappear and DiffPanel/FilePreview crash with "Failed to fetch dynamically imported module". Listen for Vite's vite:preloadError and reload once (with cooldown) so the new asset map loads. Co-authored-by: Enrico Polanski <16064771+enricopolanski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open tabs keep hashed dynamic-import URLs from the previous build. After a deploy those chunks disappear, so opening DiffPanel / FilePreview crashes with
Failed to fetch dynamically imported module.Install Vite's
vite:preloadErrorhandler at app boot and reload (with a short cooldown so real outages do not spin) so the browser picks up the new index + asset map.Test plan
vp test run apps/web/src/vitePreloadRecovery.test.tsopened by enricopolanski in chat thread Discord · Discord · T3