Repository navigation
DNM: soak the replica-recovery step against the litep2p provider-store fix - #13380
Closed
DenzelPenzel wants to merge 7 commits into
Closed
DenzelPenzel wants to merge 7 commits into
DenzelPenzel wants to merge 7 commits into
Conversation
Patches litep2p to paritytech/litep2p#666 so this branch can run the soak past the 20-providers-per-key limit where #665 panics nodes out of the network. The KademliaEvent::PeersDiscovered arm is unrelated to the fix - the branch sits on litep2p master, which added that event in #611, and sc-network has to compile against it.
…ent-store-v2-replica-recovery-litep2p665 # Conflicts: # Cargo.lock
The orchestrator otherwise brings a whole level up at once, and the apiserver drops the exec connections partway through: two runs here died at 35 and 39 of 43 nodes with 'deadline has elapsed'. A 102-node run with this set spawned cleanly in ten minutes, so the size is not the problem - the burst is.
…replica-recovery' into denzelpenzel/statement-store-v2-replica-recovery-litep2p665 # Conflicts: # .github/workflows/zombienet_statement-store-soak.yml
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. This exists only to run the soak from #13378 on the cluster with the
litep2p fix patched in.
Builds on top of #13378 (the replica outage and recovery step) and patches litep2p to
paritytech/litep2p#666, the fix for paritytech/litep2p#665: without it a node evicted
from a key's provider list panics in
MemoryStore::remove_local_provideron the nextepoch rollover, leaving the pod Running with its networking dead. Any run above 20
providers on one key hits it.
Sized at 40 nodes / 600s: above the 20-providers threshold, so the fix is actually
exercised, and short enough to finish well inside the hour the runner's k8s credentials
last (see the token expiry issue - runs past ~1h get 401 on the closing log scan).
Run it with:
soak_nodesandsoak_secsare dispatch inputs, so the size can be changed per runwithout touching the branch.
Close once #13378 has been exercised.