Repository navigation
Report SubstreamOpenFailure when switching to secondary connection - #664
Merged
Merged
Conversation
Right now it can happen that we do not report a closed connection to the upper layers. Making it look like the connection is still open and is not never removed, rendering the peer unconnectabble. This pull request solves this by preventing any kind of errors being propagated from the inner connection calls. All errors are getting handled, close the connection and one unified path reports the connection close.
bkchr
reviewed
Sep 11, 2026
bkchr
left a comment
bkchr
left a comment
Member
There was a problem hiding this comment.
Do we actually need this? Because they should be informed about the closed connection and then, drop all substreams?
Collaborator
Author
They are not while the secondary connection exists. |
bkchr
reviewed
Sep 29, 2026
bkchr
approved these changes
Sep 29, 2026
skunert
approved these changes
Sep 29, 2026
skunert
added a commit
that referenced
this pull request
Oct 2, 2026
## [0.16.0] - 2026-09-30 - kad: Fix local provider eviction and removal panics ([#666](#666)) - Report `SubstreamOpenFailure` when switching to secondary connection ([#664](#664)) - Ensure we report connection closed to the upper layers ([#663](#663)) - kad: Implement client-server mode for Kademlia ([#611](#611)) --- > **Reviewer action required:** the changelog entries above are auto-generated from merged PRs and are **unsorted**. Please edit `CHANGELOG.md` on this branch to: > - Group the entries under `### Added` / `### Changed` / `### Fixed`. > - Add a short summary paragraph at the top of the `## [0.16.0]` section. > > Then **commit the adjusted `CHANGELOG.md` to this PR**. **After merging:** run the **Release Publish** workflow from the Actions tab with version `0.16.0` to tag `master` and publish to crates.io. See `RELEASING.md`. --- > _CI note: GitHub does not run `pull_request` workflows on PRs opened by `GITHUB_TOKEN`. If CI hasn't started on this PR, push an empty commit to trigger it:_ > ```bash > git fetch origin && git checkout release-v0.16.0 > git commit --allow-empty -m "trigger ci" && git push > ``` --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DenzelPenzel <denis.samsonov@parity.io> Co-authored-by: Sebastian Kunert <mail@skunert.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures in-flight requests that can't succeed anymore are terminated.