Repository navigation
Conversation
lexnv
requested review from
dmitry-markin and
lexnv
and removed request for
dmitry-markin
August 24, 2026 09:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kademlia spec requires implementations to handle further requests on a substream a peer alreadysent one on, and litep2p was closing it after the first response, which is why go-libp2p keepslosing its cached stream mid conversation. Substreams the remote opened now go back to reading oncethe response is written, reusing the existing 15s read timeout as the idle window, and
ADD_PROVIDERno longer drops the substream just because the spec gives it no reply. A failure onone of those substreams is also no longer treated as the peer disconnecting, which previously failed every outbound query in flight with that peer whenever an inbound substream timed out.Closes #467