Skip to content

build: fixes for newer Rust - #146

Merged
hug-dev merged 1 commit into
parallaxsecond:mainfrom
dsseng:modern-rust-fixes
Jan 14, 2026
Merged

build: fixes for newer Rust#146
hug-dev merged 1 commit into
parallaxsecond:mainfrom
dsseng:modern-rust-fixes

Conversation

@dsseng

@dsseng dsseng commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Adapt newest best practices according to Clippy, fix compiler warnings.

Also build mbedTLS concurrently for faster CI builds.

Signed-off-by: Dmitrii Sharshakov d3dx12.xx@gmail.com

@dsseng

dsseng commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

@hug-dev hopefully this makes CI pass on both MSRV and current, could you please approve the workflow to run? Thank you!

hug-dev
hug-dev previously approved these changes Nov 24, 2025
View reviewed changes

@hug-dev hug-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this repo ❤️
Will see who else could review it

@dsseng

dsseng commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

Thanks! It seems I missed this part when testing locally: I don't have mbedtls on the host system and have excluded those parts of CI. Will revisit using a container to execute all parts. Sorry for missing this.

I'll most likely take care of that later this week or weekend.

@dsseng

dsseng commented Nov 30, 2025

Copy link
Copy Markdown
Contributor Author

@hug-dev sorry for taking a long time to apply a fix, hopefully it all passes now, at least locally

@hug-dev

hug-dev commented Dec 2, 2025

Copy link
Copy Markdown
Member

One last error 😢
If it's because the low version of Rust we use in the MSRV job, we could bump it if a newer version is available in the main Ubuntu repos.

@dsseng
build: fixes for newer Rust
8b8cf73 
Adapt newest best practices according to Clippy, fix compiler warnings.

Also build mbedTLS concurrently for faster CI builds.

Signed-off-by: Dmitrii Sharshakov <d3dx12.xx@gmail.com>
@dsseng
dsseng force-pushed the modern-rust-fixes branch from a4b7ee3 to 8b8cf73 Compare December 6, 2025 09:05
@dsseng

dsseng commented Dec 6, 2025

Copy link
Copy Markdown
Contributor Author

One last error 😢 If it's because the low version of Rust we use in the MSRV job, we could bump it if a newer version is available in the main Ubuntu repos.

Sorry, fixed that now! This way the source should satisfy both the type constraints of 1.66 and stricter Clippy rules of 1.91

@dsseng
dsseng requested a review from hug-dev December 6, 2025 09:06
hug-dev
hug-dev approved these changes Dec 9, 2025
View reviewed changes

@hug-dev hug-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!! Thanks!

@hug-dev
hug-dev requested a review from ionut-arm December 9, 2025 12:30
@hug-dev

hug-dev commented Jan 7, 2026

Copy link
Copy Markdown
Member

Trying to bring in a few more reviewers ❤️
If it does not work out, I could temporarily lift the 2 reviewers requirements to allow you to push your changes faster! Would be silly not to bring this crate up to date

@hug-dev
hug-dev merged commit 4f03a24 into parallaxsecond:main Jan 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hug-dev hug-dev hug-dev approved these changes
@ionut-arm ionut-arm Awaiting requested review from ionut-arm
@gowthamsk-arm gowthamsk-arm Awaiting requested review from gowthamsk-arm
@billatarm billatarm Awaiting requested review from billatarm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsseng @hug-dev