Repository navigation
build: make psa-crypto-sys no_std, fix zeroize with no_std - #145
Merged
Merged
Conversation
Contributor
Author
|
These CI failures are also present on main. I could perhaps take a look this weekend and send a PR for fixing those, please let me know if that's wanted |
Member
|
Hello! Thanks for your effort contributing into this repo!! It has been a bit left on the side those past few years... If it's needed though, I could also take a look at open issues/PRs and try to freshen it up! There is another open issue about making it |
Contributor
Author
|
I'm working on fixing clippy errors, will submit a separate PR to be merged before this |
Member
|
Please feel free to continue working on this if interested, I will review and merge it myself :) |
Contributor
Author
|
Will rebase this evening, thank you |
As psa-crypto-sys does not rely on any std features, it should be safe to completely switch its bindgen options to use core, and mark it as no_std. This allows this crate to be used in embedded applications such as TrustedFirmware-M Secure Partitions. zeroize should not need `alloc` default feature, as this crate does not make use of Vec or Box and does not derive zeroize on them. Disable all default features to avoid unnecessary dependency on std. Tested to provide access to hash functions via `operations` feature in a TF-M Secure Partition sample. Signed-off-by: Dmitrii Sharshakov <d3dx12.xx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As psa-crypto-sys does not rely on any std features, it should be safe
to completely switch its bindgen options to use core, and mark it as
no_std. This allows this crate to be used in embedded applications such
as TrustedFirmware-M Secure Partitions.
zeroize should not need
allocdefault feature, as this crate does notmake use of Vec or Box and does not derive zeroize on them. Disable all
default features to avoid unnecessary dependency on std.
Tested to provide access to hash functions via
operationsfeature ina TF-M Secure Partition sample.
Signed-off-by: Dmitrii Sharshakov d3dx12.xx@gmail.com