Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/notes/2.34.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ Published Pants binaries are now compiled with a new `dist` Cargo profile that e

Pants option config files are now parsed as TOML 1.1 rather than TOML 1.0. This covers `pants.toml` and any other file named by `[GLOBAL].pants_config_files`, the rcfiles named by `[GLOBAL].pantsrc_files` (`/etc/pantsrc`, `~/.pants.rc` and `.pants.rc` by default), and `.toml` files referenced by `@fromfile` option values. Inline tables may now span multiple lines and end with a trailing comma, strings may use the `\e` and `\xHH` escapes, and times may omit their seconds. TOML 1.1 only adds syntax to TOML 1.0, so existing files continue to parse unchanged. TOML files read by backends, such as `pyproject.toml`, are unaffected.

Conditioned a previously unconditional 'chmod' of a file in the unpacked pants code. This allows users to use a read-only venv.

### Goals

### Backends
Expand Down
3 changes: 2 additions & 1 deletion src/python/pants/engine/embedded_binary.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ def get_embedded_binary(binary_name: str) -> str | None:
importlib.resources.files("pants.bin").joinpath(binary_name)
) as bin_path:
if os.path.isfile(bin_path):
os.chmod(bin_path, 0o755)
if not os.access(bin_path, os.X_OK):
os.chmod(bin_path, 0o755)
return str(bin_path)
return None
Loading