Run pex on a suitable interpreter when resolving from a uv venv - #23643
Merged
benjyw merged 1 commit intoAug 25, 2026
Conversation
benjyw
commented
Aug 24, 2026
| req_strings = () | ||
|
|
||
| venv_repos: list[VenvRepository] = [] | ||
| python: PythonExecutable | None = None |
Contributor
Author
There was a problem hiding this comment.
To clarify: we are already setting python to non-None below in some cases, this just ensures the name always exists in this scope.
Contributor
Author
|
Fixes #23635 |
Contributor
Author
|
This bug was introduced in #23427, where the interpreter setting was removed. |
benjyw
commented
Aug 24, 2026
| lock = Lockfile("test.lock", url_description_of_origin="test uv lockfile", resolve_name="test") | ||
| pex_data = create_pex_and_get_all_data( | ||
| rule_runner, | ||
| pex_type=VenvPex, |
Contributor
Author
There was a problem hiding this comment.
This is the bit that makes this test fail under the conditions reported in the bug.
tdyas
approved these changes
Aug 25, 2026
| lock = Lockfile("test.lock", url_description_of_origin="test uv lockfile", resolve_name="test") | ||
| pex_data = create_pex_and_get_all_data( | ||
| rule_runner, | ||
| pex_type=VenvPex, |
tobni
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, when building a venv pex, the interpreter may not
be compatible with the originating uv venv, and will fail.