chore(deps): bump opendal to 0.58.1 - #23601
Conversation
Update the workspace OpenDAL pin and adapt Operator construction to the 0.58 API where Operator::new returns a finished operator (no finish()).
|
Hello @benjyw, I’m the OpenDAL maintainer, and I hope you’re happy with OpenDAL. We’ve recently made some good improvements, and I hope Pandas can benefit from them. Thank you in advance for the review. |
benjyw
left a comment
benjyw
left a comment
There was a problem hiding this comment.
Thanks for this - I think we can get rid of some of the verbiage and keep it simple.
|
|
||
| ### General | ||
|
|
||
| The [OpenDAL](https://opendal.apache.org/) library powering the experimental file and GitHub Actions Cache remote store providers has been upgraded from 0.57.0 to 0.58.1. |
There was a problem hiding this comment.
We can delete this release notes update - this change will be invisible to end users and plugin developers I think?
There was a problem hiding this comment.
Dropped. This is an internal crate bump, so I agree it does not belong in user-facing notes.
I don't have permission to add labels here. Could you add release-notes:not-required so CI stays green without the notes file change?
| scope: String, | ||
| options: RemoteStoreOptions, | ||
| ) -> Result<Provider, String> { | ||
| // Operator::new returns a finished operator in OpenDAL 0.58+; layers are |
There was a problem hiding this comment.
This comment might be more confusing than illuminating. It makes sense in the context of this PR, but a future reader won't have the pre-0.58 context, so they will not know what this information is for. I think it's fine to delete.
benjyw
added
the
release-notes:not-required
Address review: this OpenDAL bump is internal, and the Operator::new comment is only useful in the context of the 0.58 migration.
2 participants
Summary
Bump the workspace OpenDAL dependency from 0.57.0 to 0.58.1 so Pants tracks the current stable release for the experimental file and GitHub Actions Cache remote providers.
OpenDAL 0.58 returns a finished
OperatorfromOperator::new, so construction no longer callsfinish()after layering. Feature pins are unchanged (layers-*,services-memory/fs/ghac,default-features = false).This keeps the remote store path on a maintained OpenDAL line and picks up the 0.58.1 crate-split / layer packaging fixes without changing provider behavior beyond the constructor API adaptation.