Skip to content

fix: downgrade x/sync and x/sys to versions compatible with Go 1.20 - #758

Merged
panjf2000 merged 2 commits into
devfrom
copilot/fix-ci-failure
May 25, 2026
Merged

panjf2000 merged 2 commits into
devfrom
copilot/fix-ci-failure

Conversation

Copilot AI commented May 25, 2026 •

Copy link
Copy Markdown
Contributor

Commit dad475e bumped golang.org/x/sync to v0.20.0 and golang.org/x/sys to v0.45.0, both of which require Go 1.25+. CI tests against Go 1.20, so all builds broke.

  • Reverted golang.org/x/sync to v0.11.0 (last version requiring only Go 1.18)
  • Reverted golang.org/x/sys to v0.30.0 (last version requiring only Go 1.18)
  • Added inline comments in go.mod documenting the version ceilings to prevent recurrence
golang.org/x/sync v0.11.0 // don't upgrade beyond v0.11.0, v0.12.0+ requires Go 1.23+
golang.org/x/sys v0.30.0 // don't upgrade beyond v0.30.0, v0.31.0+ requires Go 1.23+

The other dependency bumps from that commit (ants/v2, testify, zap) are fine—they only require Go 1.17–1.19.

…patible with Go 1.20

golang.org/x/sync v0.20.0 and golang.org/x/sys v0.45.0 require Go 1.25+,
but CI tests on Go 1.20. Revert these to v0.11.0 and v0.30.0 respectively.
Copilot AI changed the title fix: downgrade golang.org/x/sync and golang.org/x/sys to Go 1.20-compatible versions fix: downgrade x/sync and x/sys to versions compatible with Go 1.20 May 25, 2026
Copilot AI requested a review from panjf2000 May 25, 2026 02:14
@codecov

codecov Bot commented May 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.38%. Comparing base (91cf015) to head (5f102fa).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #758   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files          22       22           
  Lines        2402     2402           
=======================================
  Hits         2027     2027           
  Misses        255      255           
  Partials      120      120           
Flag Coverage Δ
unittests 84.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@panjf2000
panjf2000 marked this pull request as ready for review May 25, 2026 02:47
Copilot AI review requested due to automatic review settings May 25, 2026 02:47

@panjf2000 panjf2000 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panjf2000
panjf2000 merged commit fd7ce4b into dev May 25, 2026
35 of 36 checks passed
@panjf2000
panjf2000 deleted the copilot/fix-ci-failure branch May 25, 2026 02:48
Copilot AI removed the request for review from Copilot May 25, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants