BUG: Fix to_dict(orient='index') to apply 'into' to nested mappings#66034
Open
C1-BA-B1-F3 wants to merge 1 commit into
Open
BUG: Fix to_dict(orient='index') to apply 'into' to nested mappings#66034C1-BA-B1-F3 wants to merge 1 commit into
C1-BA-B1-F3 wants to merge 1 commit into
Conversation
Fixes GH#65778 Previously, DataFrame.to_dict(orient='index', into=MyDict) only applied the 'into' parameter to the outer mapping, leaving nested row mappings as plain dict. This fix ensures 'into' is applied consistently to both outer and nested mappings. Changes: - Modified all three return paths in the 'index' orient branch to use into_c for nested mappings instead of dict() - Added tests for OrderedDict, defaultdict, mixed dtypes, and all object dtype cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #65778
This PR fixes a bug where
DataFrame.to_dict(orient='index', into=MyDict)only applied theintoparameter to the outer mapping, leaving nested row mappings as plaindict.Example
Changes
orient='index'branch to useinto_cfor nested mappings instead ofdict()Testing
Added comprehensive tests covering:
test_to_dict_index_into_nested- Tests OrderedDict and defaultdicttest_to_dict_index_into_nested_mixed_dtypes- Tests with mixed column typestest_to_dict_index_into_nested_all_object- Tests with all object columnsAll new tests pass.