BUG: Fix Memory Leak in read_csv#66033
Merged
Merged
Conversation
| bint allow_leading_cols | ||
| uint64_t parser_start # this is modified after __init__ | ||
| const char *encoding_errors | ||
| object _encoding_errors |
Member
Author
There was a problem hiding this comment.
No, it should be an object.
The element that PyBytes_AsString receives is an object. And the goal of this member is to keep a valid reference for self.encoding_errors.
Member
There was a problem hiding this comment.
ehh, can do this in a separate step
jbrockmendel
approved these changes
Jun 26, 2026
Member
|
thanks @Alvaro-Kothe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.I used the reproduction from #19941 (comment) to start solving the problem, after solving that, couldn't reproduce the original issue with the
ThreadPool.Reproduction
LSan report: