TST: groupby with multi-day Grouper and closed="right" on intraday data (GH#43896)#66030
Merged
Merged
Conversation
…ta (GH#43896) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jbrockmendel
added
Testing
hamdanal
pushed a commit
to hamdanal/pandas
that referenced
this pull request
Jun 27, 2026
…ta (GH#43896) (pandas-dev#66030) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #43896
Adds a regression test for
df.groupby(Grouper(freq="2D", closed="right"))on intraday data, which used to raiseValueError: Values falls before first binfromgenerate_bins_dt64.The underlying bug was fixed by GH-55283 (released in 2.1.2), which replaced the
is_superperiod(self.freq, "D")heuristic in_adjust_bin_edgeswith an explicit allowlist of super-daily rule codes. That heuristic only inspected the base frequency, so it misfired on multi-day freqs like2D, rolling the first bin edge forward to the last nanosecond of the day (ahead of the first intraday value). No regression test referenced this issue.