BUG/CLN: clean-up get_values logic in objToJSON#65744
Merged
jorisvandenbossche merged 6 commits intoJun 26, 2026
Merged
Conversation
mroeschke
approved these changes
May 29, 2026
Julian-Harbeck
approved these changes
May 29, 2026
Julian-Harbeck
left a comment
Julian-Harbeck
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Do I understand it correctly that the tz special casing is not needed anymore since essentially we have replaced obj.values with obj._values_for_json which calls obj.__array__ under the hood, same as before in the special case?
Member
Author
|
That is my understanding as well, yes |
Member
|
I think this addresses the bugfix portion of #66007. Can you port the test and whatsnew from that |
jorisvandenbossche
changed the title
Member
Author
Ah, good catch, those tests indeed pass now. Added |
jbrockmendel
approved these changes
Jun 26, 2026
hamdanal
pushed a commit
to hamdanal/pandas
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #65127 (cc @Julian-Harbeck)
Cleans up that "get_values" logic to just rely on
_values_from_json(except for MultiIndex). That removes the specific check for Index with tz to not go through.values.In the end the code is not much shorter, but I think should be easier to follow (it's just first checking for MultiIndex, and in that case doing
.values, and otherwise accessingobj.array._values_for_json(), with a bunch of error checking)