fix: replace bare except clauses with specific exception types#268
Open
koteshyelamati wants to merge 1 commit into
Open
fix: replace bare except clauses with specific exception types#268koteshyelamati wants to merge 1 commit into
koteshyelamati wants to merge 1 commit into
Conversation
Signed-off-by: Kotesh Kumar Yelamati <yelamatikoteshkumar@gmail.com>
Collaborator
|
There are several unit tests that appear to be failing. Have you tried to analyze those failures to see why they occur, and ideally fix the code changes so that the tests pass? I suppose it is possible that the tests should have been failing before, but were passing for some incorrect reason, but that would take investigation to find out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare
except:clauses catchBaseException, which includesSystemExit,KeyboardInterrupt, andGeneratorExit— signals that should generally propagate. This PR replaces them with specific exception types:except AttributeError:— for string method calls on non-string input inparse_ports()except ValueError:— forint()parsing and range parsing inparse_ports()except ImportError:— for optionalpynngimportexcept Exception:— for module imports, platform operations, test execution, and dynamic code executionNo behaviour change for normal flows; only pathological signals (
KeyboardInterruptetc.) are now able to propagate correctly.