Skip to content

Derive Go Docker tag from Dockerfile's GO_VERSION in update.sh #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Devansh-567 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Derive Go Docker tag from Dockerfile's GO_VERSION in update.sh #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion codegen/update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ pushd "$THIS_DIR/.." >/dev/null

docker build -t p4runtime-ci -f codegen/Dockerfile .

# Read the Go version from the Dockerfile so this script and the CI image
# can't drift out of sync with each other.
GO_VERSION="$(sed -n 's/^ARG GO_VERSION=//p' codegen/Dockerfile)"
if [ -z "$GO_VERSION" ]; then
echo "Could not determine GO_VERSION from codegen/Dockerfile" >&2
exit 1
fi

tmpdir="$(mktemp -d /tmp/p4rt.XXXXXX)"

docker run --rm \
Expand All @@ -47,7 +55,7 @@ docker run --rm -u "$(id -u):$(id -g)" \
-e "GOPATH=/tmp/gopath" \
-v "$(pwd):/p4runtime" \
-w /p4runtime \
golang:1.20 bash -c "go mod tidy"
"golang:${GO_VERSION}" bash -c "go mod tidy"

rm -rf "$tmpdir"

Expand Down
Loading