Skip to content

Update Python version and dependencies in tag-uploads workflow#625

Open
Devansh-567 wants to merge 1 commit into
p4lang:mainfrom
Devansh-567:small_maintenance
Open

Update Python version and dependencies in tag-uploads workflow#625
Devansh-567 wants to merge 1 commit into
p4lang:mainfrom
Devansh-567:small_maintenance

Conversation

@Devansh-567

Copy link
Copy Markdown
Contributor

Summary

Small maintenance PR bumping stale CI and Python packaging version floors. No functional/behavioral changes, versions only.

Changes

1. .github/workflows/tag-uploads.yml

  • actions/setup-python@v3 = actions/setup-python@v5
    v3 runs on the deprecated Node16 runtime, which GitHub Actions now flags with deprecation warnings on every run. v5 is already what the rest of the ecosystem (and most other actions in this repo) use, so this just brings the publish-to-pypi job in line.

2. py/setup.cfg

  • python_requires = >=3.6 = >=3.8
    Python 3.6 reached end-of-life in December 2021 and isn't installable on current GitHub-hosted runner images. The declared floor was implying support that doesn't actually exist in practice. 3.8 reflects the oldest version that's realistically still testable/installable today.

  • protobuf >= 3.6.1 = protobuf >= 4.21.6

  • grpcio >= 1.17.2 = grpcio >= 1.49.1
    Both floors were set years behind what the package is actually built and tested against. Raising them to versions that are actually exercised in CI avoids advertising compatibility that isn't real and avoids users pinning ancient, insecure versions based on the stated minimum.

Signed-off-by: Devansh-567 <devansh.jay.singh@gmail.com>

@matthewtlam matthewtlam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jafingerhut jafingerhut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants