Skip to content

py: drop obsolete setuptools_scm_git_archive dependency#621

Open
Devansh-567 wants to merge 1 commit into
p4lang:mainfrom
Devansh-567:py/remove-obsolete-build-dependency
Open

py: drop obsolete setuptools_scm_git_archive dependency#621
Devansh-567 wants to merge 1 commit into
p4lang:mainfrom
Devansh-567:py/remove-obsolete-build-dependency

Conversation

@Devansh-567

Copy link
Copy Markdown
Contributor

Summary

This PR removes setuptools_scm_git_archive from py/pyproject.toml's build-system.requires.

setuptools_scm_git_archive has been archived and is no longer actively maintained. Modern versions of setuptools_scm no longer require it as a separate build dependency for standard versioning workflows, making this dependency unnecessary.

Removing the obsolete dependency simplifies the project's build requirements and reduces maintenance overhead.

Changes

  • Removed setuptools_scm_git_archive from build-system.requires in py/pyproject.toml.

Testing

  • Verified that this change only removes an unused build dependency.
  • No functional source code changes were made.

Signed-off-by: Devansh-567 <devansh.jay.singh@gmail.com>
Comment thread py/pyproject.toml
@@ -18,7 +18,6 @@
requires = [
"setuptools",
"setuptools_scm[toml]",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When asking AI whether it is safe to remove the git_archive, it recommends "setuptools_scm[toml]>=7.0.0"

Longer version of comment:

It was originally created as a plugin to allow setuptools_scm to read version numbers from .git_archival.txt files when building from a downloaded GitHub .tar.gz or .zip source archive (where the .git directory is missing).  However, starting with setuptools_scm version 7.0.0, this functionality was built directly into the core package.  If you remove it, you should ideally pin your setuptools_scm requirement to version 7.0.0 or higher to ensure the native git archive fallback still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants