-
Notifications
You must be signed in to change notification settings - Fork 517
Fix BMv2 variable-offset slice compilation (#5558) #5716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anovotarsk
wants to merge
4
commits into
p4lang:main
Choose a base branch
from
anovotarsk:anovotarsk/bmv2_variable_slice
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+379
−15
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
02af277
Fix BMv2 variable-offset slice compilation (#5558)
anovotarsk a68b73b
Make signed slice lowering test robust to frontend renaming
anovotarsk bfeaaac
Mark issue5558 BMv2 P4Testgen cases as expected failures
anovotarsk 6faaff3
Merge branch 'main' of github.com:anovotarsk/p4c into anovotarsk/bmv2…
anovotarsk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: 2026 The P4 Language Consortium | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #include <core.p4> | ||
| #include <v1model.p4> | ||
|
|
||
| header Hdr { | ||
| bit<8> a; | ||
| } | ||
|
|
||
| struct Headers { | ||
| Hdr op; | ||
| } | ||
|
|
||
| struct Meta {} | ||
|
|
||
| parser p(packet_in b, out Headers h, inout Meta m, inout standard_metadata_t sm) { | ||
| state start { | ||
| transition accept; | ||
| } | ||
| } | ||
|
|
||
| control vrfy(inout Headers h, inout Meta m) { apply {} } | ||
| control update(inout Headers h, inout Meta m) { apply {} } | ||
|
|
||
| control ingress(inout Headers h, inout Meta m, inout standard_metadata_t sm) { | ||
| apply { | ||
| bit<8> x = 0x00; | ||
| h.op.a[3:0] = x[h.op.a+:4]; | ||
| } | ||
| } | ||
|
|
||
| control egress(inout Headers h, inout Meta m, inout standard_metadata_t sm) { apply {} } | ||
|
|
||
| control deparser(packet_out b, in Headers h) { | ||
| apply { | ||
| b.emit(h.op); | ||
| } | ||
| } | ||
|
|
||
| V1Switch(p(), vrfy(), ingress(), egress(), update(), deparser()) main; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| #include <core.p4> | ||
|
|
||
| #define V1MODEL_VERSION 20180101 | ||
| #include <v1model.p4> | ||
|
|
||
| header Hdr { | ||
| bit<8> a; | ||
| } | ||
|
|
||
| struct Headers { | ||
| Hdr op; | ||
| } | ||
|
|
||
| struct Meta { | ||
| } | ||
|
|
||
| parser p(packet_in b, out Headers h, inout Meta m, inout standard_metadata_t sm) { | ||
| state start { | ||
| transition accept; | ||
| } | ||
| } | ||
|
|
||
| control vrfy(inout Headers h, inout Meta m) { | ||
| apply { | ||
| } | ||
| } | ||
|
|
||
| control update(inout Headers h, inout Meta m) { | ||
| apply { | ||
| } | ||
| } | ||
|
|
||
| control ingress(inout Headers h, inout Meta m, inout standard_metadata_t sm) { | ||
| apply { | ||
| bit<8> x = 8w0x0; | ||
| h.op.a[3:0] = x[h.op.a+:4]; | ||
| } | ||
| } | ||
|
|
||
| control egress(inout Headers h, inout Meta m, inout standard_metadata_t sm) { | ||
| apply { | ||
| } | ||
| } | ||
|
|
||
| control deparser(packet_out b, in Headers h) { | ||
| apply { | ||
| b.emit<Hdr>(h.op); | ||
| } | ||
| } | ||
|
|
||
| V1Switch<Headers, Meta>(p(), vrfy(), ingress(), egress(), update(), deparser()) main; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| #include <core.p4> | ||
|
|
||
| #define V1MODEL_VERSION 20180101 | ||
| #include <v1model.p4> | ||
|
|
||
| header Hdr { | ||
| bit<8> a; | ||
| } | ||
|
|
||
| struct Headers { | ||
| Hdr op; | ||
| } | ||
|
|
||
| struct Meta { | ||
| } | ||
|
|
||
| parser p(packet_in b, out Headers h, inout Meta m, inout standard_metadata_t sm) { | ||
| state start { | ||
| transition accept; | ||
| } | ||
| } | ||
|
|
||
| control vrfy(inout Headers h, inout Meta m) { | ||
| apply { | ||
| } | ||
| } | ||
|
|
||
| control update(inout Headers h, inout Meta m) { | ||
| apply { | ||
| } | ||
| } | ||
|
|
||
| control ingress(inout Headers h, inout Meta m, inout standard_metadata_t sm) { | ||
| @name("ingress.x") bit<8> x_0; | ||
| apply { | ||
| x_0 = 8w0x0; | ||
| h.op.a[3:0] = x_0[h.op.a+:4]; | ||
| } | ||
| } | ||
|
|
||
| control egress(inout Headers h, inout Meta m, inout standard_metadata_t sm) { | ||
| apply { | ||
| } | ||
| } | ||
|
|
||
| control deparser(packet_out b, in Headers h) { | ||
| apply { | ||
| b.emit<Hdr>(h.op); | ||
| } | ||
| } | ||
|
|
||
| V1Switch<Headers, Meta>(p(), vrfy(), ingress(), egress(), update(), deparser()) main; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.