Repository navigation
Close the CoT block a chat template opens - #514
Open
benthecarman wants to merge 1 commit into
Open
benthecarman wants to merge 1 commit into
benthecarman wants to merge 1 commit into
Conversation
When the chat template already ends the prompt with the Chain-of-Thought initializer, as Qwen3.5 does with thinking enabled, the full closed block was appended after it, so the model saw a nested block: "<think>\n<think></think>". Append only the rest of the closed block.
benthecarman
force-pushed
the
fix-template-cot-prefix
branch
from
October 22, 2026 05:46
8087f83 to
b007f3e
Compare
Owner
|
Hey, I think you caught a major bug here! However, it's not quite so easy to fix, because the template might actually insert the complete CoT block (e.g. when it defaults to disabling thinking). @Vinay-Umrethe Could you take a look, since you implemented #423? What is the best way forward here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the chat template already ends the prompt with the CoT initializer, as Qwen3.5 does with thinking enabled, the full closed block was appended after it, so the model saw a nested block:
"<think>\n<think></think>".Append only the rest of the closed block. Templates that don't insert the initializer (Qwen3, gpt-oss, GLM)AI use declaration
Check either of the following:
and fully understand it. I'm prepared to discuss the code without letting an agent speak on my behalf.