Repository navigation
fix: reject blank refusal keyword markers - #512
Open
jovial-liu wants to merge 2 commits into
Open
jovial-liu wants to merge 2 commits into
jovial-liu wants to merge 2 commits into
Conversation
jovial-liu
marked this pull request as ready for review
October 22, 2026 09:17
p-e-w
reviewed
Oct 22, 2026
| settings=Settings(keyword_markers=[]), | ||
| ) | ||
|
|
||
| self.assertFalse(scorer._is_match("This is a normal answer.")) |
Owner
There was a problem hiding this comment.
But passing an empty keyword list doesn't make sense, and should also be disallowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty keyword markers match every response, while a space matches most ordinary sentences. Both can silently inflate the keyword match rate.
This change rejects empty and whitespace-only markers during configuration validation. An empty list remains valid.
Regression tests cover invalid markers and the empty-list behavior. All 24 unit tests pass locally, along with formatting, lint, type checks, and package builds. Remote CI is awaiting maintainer approval.
I have personally reviewed and understand all changes in this PR.