Skip to content

[tests-only][full-ci] test(cli): add blobstore get and check CLI tests#12505

Open
anon-pradip wants to merge 2 commits into
owncloud:masterfrom
anon-pradip:test/cli-test-to-test-blobstore
Open

[tests-only][full-ci] test(cli): add blobstore get and check CLI tests#12505
anon-pradip wants to merge 2 commits into
owncloud:masterfrom
anon-pradip:test/cli-test-to-test-blobstore

Conversation

@anon-pradip

Copy link
Copy Markdown
Contributor

Description

Adds acceptance tests for the storage-users blobstore check and storage-users blobstore get CLI commands introduced in #12102.

New test scenarios (tests/acceptance/features/cliCommands/blobstore.feature):

Scenario Assertion
check with default size full round-trip: upload, download+verify, delete
check with custom size --blob-size=1KB accepted, round-trip passes
check with invalid size --blob-size=abc rejected with invalid --blob-size
get without flags error: either --path or both --blob-id and --space-id must be set
get non-existent blob error: download failed: could not read blob

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kw-security

kw-security commented Jul 6, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@ishabaral ishabaral mentioned this pull request Jul 6, 2026
13 tasks
@anon-pradip anon-pradip force-pushed the test/cli-test-to-test-blobstore branch 2 times, most recently from d3d6252 to bc71fe2 Compare July 8, 2026 04:13
@anon-pradip anon-pradip force-pushed the test/cli-test-to-test-blobstore branch 2 times, most recently from d18b24f to 49d5ab7 Compare July 10, 2026 06:05
@anon-pradip anon-pradip force-pushed the test/cli-test-to-test-blobstore branch from 49d5ab7 to 5ebe037 Compare July 10, 2026 06:08
@anon-pradip anon-pradip marked this pull request as ready for review July 10, 2026 11:19
@anon-pradip anon-pradip requested a review from a team as a code owner July 10, 2026 11:19
And the command output should contain "Blobstore check successful."


Scenario: administrator checks the blobstore with an invalid blob size

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also check with valid blob size.



Scenario: administrator tries to get a non-existent blob from the blobstore
When the administrator gets a non-existent blob from the blobstore using the CLI

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When the administrator gets a non-existent blob from the blobstore using the CLI
When the administrator tries to get a non-existent blob from the blobstore using the CLI

}

/**
* @When the administrator gets a non-existent blob from the blobstore using the CLI

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @When the administrator gets a non-existent blob from the blobstore using the CLI
* @When the administrator tries to get a non-existent blob from the blobstore using the CLI

Scenario: administrator tries to get a blob without providing required flags
When the administrator tries to get a blob from the blobstore using the CLI
Then the command should be unsuccessful
And the command output should contain "either --path or both --blob-id and --space-id must be set"

@nabim777 nabim777 Jul 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command also supports the flag --path. So, if possible, it would be good to add a test that checks it with a valid path as well.

@nabim777

Copy link
Copy Markdown
Member

I also saw these commands in the README. Is there a plan to add tests for them, or are they being skipped because they cannot be tested?

check  check blobstore connectivity via an upload/download/delete round-trip
get    get a blob from the blobstore by ID

REF: https://github.com/owncloud/ocis/blob/master/services/storage-users/README.md#check-and-inspect-the-blobstore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants