[tests-only][full-ci] test(cli): add blobstore get and check CLI tests#12505
Open
anon-pradip wants to merge 2 commits into
Open
[tests-only][full-ci] test(cli): add blobstore get and check CLI tests#12505anon-pradip wants to merge 2 commits into
anon-pradip wants to merge 2 commits into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
d3d6252 to
bc71fe2
Compare
d18b24f to
49d5ab7
Compare
49d5ab7 to
5ebe037
Compare
| And the command output should contain "Blobstore check successful." | ||
|
|
||
|
|
||
| Scenario: administrator checks the blobstore with an invalid blob size |
Contributor
There was a problem hiding this comment.
Can we also check with valid blob size.
nabim777
reviewed
Jul 13, 2026
|
|
||
|
|
||
| Scenario: administrator tries to get a non-existent blob from the blobstore | ||
| When the administrator gets a non-existent blob from the blobstore using the CLI |
Member
There was a problem hiding this comment.
Suggested change
| When the administrator gets a non-existent blob from the blobstore using the CLI | |
| When the administrator tries to get a non-existent blob from the blobstore using the CLI |
nabim777
reviewed
Jul 13, 2026
| } | ||
|
|
||
| /** | ||
| * @When the administrator gets a non-existent blob from the blobstore using the CLI |
Member
There was a problem hiding this comment.
Suggested change
| * @When the administrator gets a non-existent blob from the blobstore using the CLI | |
| * @When the administrator tries to get a non-existent blob from the blobstore using the CLI |
nabim777
reviewed
Jul 13, 2026
| Scenario: administrator tries to get a blob without providing required flags | ||
| When the administrator tries to get a blob from the blobstore using the CLI | ||
| Then the command should be unsuccessful | ||
| And the command output should contain "either --path or both --blob-id and --space-id must be set" |
Member
There was a problem hiding this comment.
The command also supports the flag --path. So, if possible, it would be good to add a test that checks it with a valid path as well.
Member
|
I also saw these commands in the README. Is there a plan to add tests for them, or are they being skipped because they cannot be tested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds acceptance tests for the
storage-users blobstore checkandstorage-users blobstore getCLI commands introduced in #12102.New test scenarios (
tests/acceptance/features/cliCommands/blobstore.feature):--blob-size=1KBaccepted, round-trip passes--blob-size=abcrejected withinvalid --blob-sizeeither --path or both --blob-id and --space-id must be setdownload failed: could not read blobRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: