Skip to content

[OCISDEV-969] fix: ocis_multi deployment with proper ldap groups#12466

Open
jvillafanez wants to merge 1 commit into
owncloud:masterfrom
jvillafanez:fix_ocismulti_deployment
Open

[OCISDEV-969] fix: ocis_multi deployment with proper ldap groups#12466
jvillafanez wants to merge 1 commit into
owncloud:masterfrom
jvillafanez:fix_ocismulti_deployment

Conversation

@jvillafanez

Copy link
Copy Markdown
Member

Description

Some LDAP group changes broke the setup. It was fixed in the ocis container, but not in the ocis-ocm.
In addition, the OCM domain wasn't being replaced, so there were problems if the domain wasn't the default one.

Note that the "ocis.ocm.web.config.json" config file still needs manual changes for the domain.

Related Issue

  • Fixes <issue_link>

Motivation and Context

The deployment example should work now as intended.

How Has This Been Tested?

Start the deployment example and login with different users in the ocis and ocis-ocm servers.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs

update-docs Bot commented Jun 25, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kw-security

kw-security commented Jun 25, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as maintainer. This is a clean, correct fix for the ocis_multi deployment example. ✅

What it does, and why it's right:

  1. LDAP group object classes for ocis-ocm — On master the working ocis service already uses OCIS_LDAP_GROUP_OBJECTCLASS: "groupOfNames" + OCIS_LDAP_GROUP_ADDITIONAL_OBJECTCLASSES: "ownCloudGroup", but the ocis-ocm service still carried the old OCIS_LDAP_GROUP_OBJECTCLASS: "owncloudGroup" with no additional object class. This PR brings ocis-ocm in line with ocis, including the exact ownCloudGroup casing. This matches the migration that already landed for the main container and explains the "fixed in ocis but not ocis-ocm" symptom in the description.

  2. OCM domain replacement in the Keycloak realm import — The entrypoint now adds a second sed expression substituting ocis.ocm.owncloud.test${OCIS_OCM_DOMAIN}, plus the matching OCIS_OCM_DOMAIN: ${OCIS_OCM_DOMAIN:-ocis.ocm.owncloud.test} env on the keycloak service. Verified against ocis-realm.dist.json: it has 5 occurrences each of ocis.owncloud.test and ocis.ocm.owncloud.test, so both now get rewritten when a non-default domain is used. The two sed patterns are disjoint (ocis.owncloud.test is not a substring of ocis.ocm.owncloud.test, since .ocm. sits between), so left-to-right expression ordering is safe in both directions — no double-substitution or clobbering. The stale commented-out single-expression line was correctly superseded.

Minor / non-blocking:

  • The leftover commented-out # sed -e "s/ocis.ocm..." line just below is now dead and could be dropped for tidiness, but it's harmless.
  • As the description notes, ocis.ocm.web.config.json still needs manual domain edits — worth a follow-up to make the example fully domain-agnostic, but out of scope here.

Changelog: This is a deployment-example-only change (no product source touched). Per the repo's prevailing convention, example-only fixes generally ship without a changelog/unreleased/ fragment, so no fragment is required (n-a).

Verdict: approve. Behavior-correct, scoped, and consistent with the already-migrated ocis service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants