Skip to content

feat: import Polls app and Vinzenz Rosenkranz publisher page#98

Open
DeepDiver1975 wants to merge 1 commit into
mainfrom
import-vinzenz-rosenkranz
Open

feat: import Polls app and Vinzenz Rosenkranz publisher page#98
DeepDiver1975 wants to merge 1 commit into
mainfrom
import-vinzenz-rosenkranz

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Member

Imports the Polls app (v0.8.1) from the legacy marketplace (marketplace.owncloud.com) together with its publisher Vinzenz Rosenkranz.

Details

  • Validates against the same checks CI runs (validateRelease).
  • ⚠️ No screenshots: the three screenshot URLs (raw.githubusercontent.com/nextcloud/polls/master/screenshots/...) now return 404 — the upstream repo restructured since the 2018 release, so the images are no longer available to ingest. The listing has no screenshots as a result.
  • publishers/vinzenz-rosenkranz/publisher.jsonenabled: false (page was private, isPagePublic: false), claiming polls.
  • Historical downloads (9,800) and release date recorded in the data files.

Supersedes

Replaces the placeholder publisher PR #90, which will be closed.

🤖 Generated with Claude Code

Imports the Polls app (v0.8.1) from the legacy marketplace
(marketplace.owncloud.com) and adds its publisher, Vinzenz Rosenkranz.

The app validates against the same checks CI runs (validateRelease).
Its three screenshot URLs (raw.githubusercontent.com/nextcloud/polls)
now return 404 — the upstream repo restructured since the 2018 release —
so no screenshots could be ingested; the listing has none. Historical
download total (9,800) and the real release date are recorded in
data/downloads-baseline.json and data/created.json.

Publisher vinzenz-rosenkranz is disabled (enabled: false) — its page was
private on the old marketplace (isPagePublic: false) — and claims polls.
Supersedes the placeholder publisher PR #90.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975

Copy link
Copy Markdown
Member Author

Review — import Polls app + Vinzenz Rosenkranz publisher (agent review, DeepDiver1975)

Looks correct and consistent with the other legacy imports. Findings:

  • App data: layout is schema-conformant — apps/polls/releases/0.8.1/package.tar.gz follows the same convention as existing apps (metadata inside the tarball; no separate app-level JSON expected).
  • LFS: package.tar.gz is a valid Git-LFS pointer (oid sha256:77b0b72e…, size 4392801), matching the .gitattributes rule apps/**/*.tar.gz filter=lfs. ✅
  • Publisher ↔ app integrity: publisher.json claims ["polls"] and the polls app is imported in this same PR, so assertOwnershipIntegrity is satisfied. enabled: false correctly mirrors the legacy private page. ✅
  • No conflict with feat: add Vinzenz Rosenkranz publisher page #90: PR feat: add Vinzenz Rosenkranz publisher page #90 is already CLOSED, and this PR explicitly supersedes it; the publisher does not exist on main, so there is no duplicate. ✅
  • No secrets; website link https://github.com/nextcloud/polls resolves (200). The 404 screenshot URLs are correctly omitted per the PR description.
  • Data files: polls@0.8.1 correctly added to created.json (2018-01-18) and downloads-baseline.json (9798).

⚠️ Blocking before merge:

  1. Merge conflict — the PR is CONFLICTING/DIRTY. data/created.json and data/downloads-baseline.json drifted on main from sibling imports (feat: import Passman app and Sander Brand publisher page #94, feat: import appVNCsafe app and VNC publisher page #95, feat: import Frank de Lange apps (Reader, OPDS catalog) #96). This is a trivial textual JSON conflict on adjacent keys, not a data problem — please rebase on main to resolve.
  2. CI validate did not run (empty status check rollup). After rebasing, confirm the validateRelease check is green before merge.

Changelog: n-a (repo has no changelog convention).

🤖 Generated with Claude Code

1 similar comment
@DeepDiver1975

Copy link
Copy Markdown
Member Author

Review — import Polls app + Vinzenz Rosenkranz publisher (agent review, DeepDiver1975)

Looks correct and consistent with the other legacy imports. Findings:

  • App data: layout is schema-conformant — apps/polls/releases/0.8.1/package.tar.gz follows the same convention as existing apps (metadata inside the tarball; no separate app-level JSON expected).
  • LFS: package.tar.gz is a valid Git-LFS pointer (oid sha256:77b0b72e…, size 4392801), matching the .gitattributes rule apps/**/*.tar.gz filter=lfs. ✅
  • Publisher ↔ app integrity: publisher.json claims ["polls"] and the polls app is imported in this same PR, so assertOwnershipIntegrity is satisfied. enabled: false correctly mirrors the legacy private page. ✅
  • No conflict with feat: add Vinzenz Rosenkranz publisher page #90: PR feat: add Vinzenz Rosenkranz publisher page #90 is already CLOSED, and this PR explicitly supersedes it; the publisher does not exist on main, so there is no duplicate. ✅
  • No secrets; website link https://github.com/nextcloud/polls resolves (200). The 404 screenshot URLs are correctly omitted per the PR description.
  • Data files: polls@0.8.1 correctly added to created.json (2018-01-18) and downloads-baseline.json (9798).

⚠️ Blocking before merge:

  1. Merge conflict — the PR is CONFLICTING/DIRTY. data/created.json and data/downloads-baseline.json drifted on main from sibling imports (feat: import Passman app and Sander Brand publisher page #94, feat: import appVNCsafe app and VNC publisher page #95, feat: import Frank de Lange apps (Reader, OPDS catalog) #96). This is a trivial textual JSON conflict on adjacent keys, not a data problem — please rebase on main to resolve.
  2. CI validate did not run (empty status check rollup). After rebasing, confirm the validateRelease check is green before merge.

Changelog: n-a (repo has no changelog convention).

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant