Skip to content

Proxy: Fix nil pointer panic in BuildStreamURL and resource leak in ParseBody #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sevico wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Proxy: Fix nil pointer panic in BuildStreamURL and resource leak in ParseBody #4659

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e124f9f
Proxy: Fix nil pointer panic in BuildStreamURL and resource leak in P…
sevico Apr 11, 2026
df7a5ad
Proxy: Add UT coverage for nil pointer and resource leak fixes
suzp1984 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,12 @@ func ApiCORS(ctx context.Context, w http.ResponseWriter, r *http.Request) bool {

// ParseBody read the body from r, and unmarshal JSON to v.
func ParseBody(r io.ReadCloser, v interface{}) error {
defer r.Close()

b, err := io.ReadAll(r)
if err != nil {
return errors.Wrapf(err, "read body")
}
defer r.Close()

if len(b) == 0 {
return nil
Expand All @@ -97,7 +98,7 @@ func BuildStreamURL(r string) (string, error) {
defaultVhost := !strings.Contains(u.Hostname(), ".")

// If hostname is actually an IP address, it's __defaultVhost__.
if ip := net.ParseIP(u.Hostname()); ip.To4() != nil {
if ip := net.ParseIP(u.Hostname()); ip != nil && ip.To4() != nil {
defaultVhost = true
}

Expand Down
Loading