🐛 Detect GitHub CLI and Nextcloud release workflows - #5202
Open
CAOShurong wants to merge 1 commit into
Open
Conversation
Signed-off-by: Shurong Cao <170531907+CAOShurong@users.noreply.github.com>
CAOShurong
requested review from
AdamKorcz and
justaugustus
and removed request for
a team
August 27, 2026 22:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix: extend the GitHub Actions Packaging detector to recognize release workflows that publish with the GitHub CLI or the official Nextcloud App Store API.
What is the current behavior?
IsPackagingWorkflowrecognizes package-manager actions and commands, but it does not recognizegh release create/upload/editor a workflow posting tohttps://apps.nextcloud.com/api/v1/apps/releases. Such workflows are reported as not being publishing workflows.What is the new behavior?
The detector now recognizes those two release mechanisms. Read-only
gh release viewremains a non-match so inspection commands are not treated as publication.The existing check still requires a successful workflow run before it awards a packaging result; this PR only closes the static workflow-recognition gap.
Which issue(s) this PR fixes
Fixes #5201
Special notes for your reviewer
The matcher uses the existing
JobMatcherStep.Runmechanism and adds focused actionlint fixtures for GitHub CLI publication, Nextcloud App Store publication, and the read-only GitHub CLI command.Focused verification:
go test ./checks/fileparser -run '^(TestGitHubWorkflowShell|Test_stepsMatch|TestIsPackagingWorkflow)$' -count=1go test ./checks/raw/github ./checks/evaluation -count=1go vet ./checks/fileparsergit diff --checkThe full
go test ./checks/... -count=1run remains affected by pre-existing Windows/path and fixture failures outside this change (for exampleTestIsWorkflowFileand unrelated permission/SAST fixtures).AI assistance disclosure
OpenAI Codex (GPT-5) assisted with issue triage, implementation, and test design; all changes were reviewed and verified locally by the contributor.