Repository navigation
Conversation
…n-dg/TheHealthApp into feature-162-phone-formatting
|
Contributor
Author
|
I have updated the registration country code dropdown to reflect our application's supported locales (+1, +34, +91, +86, +971). All local checks and unit tests continue to pass cleanly. |
mudabs
requested changes
Nov 13, 2026
mudabs
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, Moon, for adding the much-needed country-code selector and canonical signup payload.
Please address these items before approval:
- Normalize phone input consistently. The current change strips + during input, so the startsWith('+') branch cannot run and pasted E.164 numbers may receive a second country code.
- Use country-aware validation. The current 10 to 15 digit local-number rule rejects valid numbers for some supported countries, including Spain and the UAE.
- Add tests for non-default country codes, formatted or pasted numbers, and the resulting submitted payload.
- Document the display and stored phone formats, and localize the Country Code label.
- Re-run the full CI workflow. The current run requires action and has no jobs, so only SonarCloud is verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Changes Made
frontend/src/pages/auth/Signup.jsx:countryCodestate initialized to+1.aria-label="Country Code") alongside the phone input.onSubmitpayload to construct canonical E.164 phone values (${countryCode}${rawDigits}).frontend/src/pages/auth/Signup.test.jsx:fillValidFormand test cases to queryselect[name="gender"]directly to prevent combobox role ambiguity.Testing Details
npm run test:run), all tests passing with zero failures.npm run lintandnpm run buildcleanly.Checklist
Closes #162